Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add share link feature #150

Merged
merged 2 commits into from
May 16, 2023
Merged

Conversation

fcollonval
Copy link
Member

The need of installing another extension to generate a shared link fade away now that you need to explicitly install this extension to enable live collaboration.

This add the share link feature through a button next to the user menu bar (top right).

It also simplifies the code by dropping the backend code (compared to jupyterlab-share-link) as there is no reason to provide link to another server than the current one.

@fcollonval fcollonval added the enhancement New feature or request label May 10, 2023
@github-actions
Copy link
Contributor

Binder 👈 Launch a Binder on branch fcollonval/jupyter_server_ydoc/ft/add-share-links

@codecov-commenter
Copy link

codecov-commenter commented May 10, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (d1d1140) 0.00% compared to head (793bb7d) 0.00%.

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #150   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files          7       7           
  Lines        453     453           
=====================================
  Misses       453     453           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jtpio
Copy link
Member

jtpio commented May 12, 2023

It also simplifies the code by dropping the backend code (compared to jupyterlab-share-link) as there is no reason to provide link to another server than the current one (a second jupyter server via jupyter-server-proxy).

To give more context about this, the original motivate in jupyterlab-link-share was to provide the correct token when running on Binder.

Would be happy to archive https://github.com/jupyterlab-contrib/jupyterlab-link-share if it is not necessary anymore.

@fcollonval
Copy link
Member Author

Thanks @jtpio for highlighting that peculiar point.
It would be great if indeed this could work on Binder - haven't tested yet.

Another point I'm missing is the support for notebook V7. But I guess this could be tackled in a specific issue as there is also a question about what to do with the side panel.

@hbcarlos
Copy link
Member

Another point I'm missing is the support for notebook V7. But I guess this could be tackled in a specific issue as there is also a question about what to do with the side panel.

For Notebook 7 support, we could use the appName or something similar to detect the distribution and reposition the different widgets. It would be great to standardize it (or maybe a different approach) so every extension can rely on that to detect the distribution.

Copy link
Member

@hbcarlos hbcarlos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants