-
-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add share link feature #150
Conversation
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #150 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 7 7
Lines 453 453
=====================================
Misses 453 453 ☔ View full report in Codecov by Sentry. |
To give more context about this, the original motivate in Would be happy to archive https://github.com/jupyterlab-contrib/jupyterlab-link-share if it is not necessary anymore. |
Thanks @jtpio for highlighting that peculiar point. Another point I'm missing is the support for notebook V7. But I guess this could be tackled in a specific issue as there is also a question about what to do with the side panel. |
For Notebook 7 support, we could use the |
ed6a361
to
793bb7d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
The need of installing another extension to generate a shared link fade away now that you need to explicitly install this extension to enable live collaboration.
This add the share link feature through a button next to the user menu bar (top right).
It also simplifies the code by dropping the backend code (compared to jupyterlab-share-link) as there is no reason to provide link to another server than the current one.