Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localize more user facing strings #49

Open
jtpio opened this issue Jun 8, 2024 · 2 comments
Open

Localize more user facing strings #49

jtpio opened this issue Jun 8, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@jtpio
Copy link
Member

jtpio commented Jun 8, 2024

Problem

Briefly looking at the code, it looks like there are a couple more strings could be localized using the JupyterLab translator, for example:

image

Proposed Solution

Use the ITranslator in more places.

@jtpio jtpio added the enhancement New feature or request label Jun 8, 2024
@brichet
Copy link
Collaborator

brichet commented Oct 11, 2024

@jtpio would it be enough to use the ITranslator ?
Don't we have to provide also the translations for each sentence somewhere (i.e. in language packs directly) ?

@jtpio
Copy link
Member Author

jtpio commented Oct 11, 2024

Yes it's enough to just use the ITranslator for the extension code itself 👍

But I think we also need to add it to this repo: https://github.com/jupyterlab/language-packs?tab=readme-ov-file#adding-a-new-extension, so it can be integrated in the translation process via crowdin.

When using the translator in the extension, we can then use the name of the extension, for example:

translator.load('jupyter-chat')

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants