Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Releases will have two version bumps #15

Open
krassowski opened this issue Apr 12, 2024 · 1 comment
Open

Releases will have two version bumps #15

krassowski opened this issue Apr 12, 2024 · 1 comment
Labels
bug Something isn't working maintenance Packaging, tests

Comments

@krassowski
Copy link
Member

Hi @brichet it looks like we independently arrived at somewhat similar monorepo implementations. I am working on jupyterlab/jupyter-collaboration#280 and in there I noticed that I have to short-circuit if any changes were made to the git, see the bump_version.py script. This is because of jupyter-releaser running the bump action for each of the python packages (jupyter-server/jupyter_releaser#567). This is just to let you know that currently the release check in this repo also bumps two versions, taking an extract from logs:

Changes:
 - chat-jupyter: 0.1.0 => 0.1.1
 - jupyterlab-collaborative-chat: 0.1.0 => 0.1.1
 - jupyterlab-ws-chat: 0.1.0 => 0.1.1

lerna info auto-confirmed
lerna info execute Skipping git tag/commit
lerna info execute Skipping git push
lerna info execute Skipping releases
lerna success version finished
Setting up build environment for missing dependencies
0.1.1
0.1.1
COMMAND: ../../scripts/bump-version.sh patch
lerna notice cli v6.4.1
lerna info ci enabled
lerna info current version 0.1.1
lerna notice FYI git repository validation has been skipped, please ensure your version bumps are correct
lerna WARN force-publish all packages
lerna info Assuming all packages changed
lerna WARN version Skipping working tree validation, proceed at your own risk

Changes:
 - chat-jupyter: 0.1.1 => 0.1.2
 - jupyterlab-collaborative-chat: 0.1.1 => 0.1.2
 - jupyterlab-ws-chat: 0.1.1 => 0.1.2
@krassowski krassowski added the bug Something isn't working label Apr 12, 2024
@brichet
Copy link
Collaborator

brichet commented Apr 13, 2024

Thanks @krassowski for opening this, I hadn't noticed this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working maintenance Packaging, tests
Projects
None yet
Development

No branches or pull requests

2 participants