Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix check-release workflow #5

Merged
merged 1 commit into from
Mar 4, 2023
Merged

Fix check-release workflow #5

merged 1 commit into from
Mar 4, 2023

Conversation

dlqqq
Copy link
Member

@dlqqq dlqqq commented Mar 4, 2023

The check-release workflow was failing because hatch-nodejs-plugin doesn't bump intra-monorepo dependency versions in package.json. For example, running hatch version 0.0.2 would not update the dependency declaration

"devDependencies": {
  ...,
  "@jupyter/ai": "^0.0.1"
}

in packages/jupyter-ai-dalle/package.json.

Thankfully, lerna version can handle such a case.

@dlqqq dlqqq added the bug Something isn't working label Mar 4, 2023
@dlqqq dlqqq merged commit a2531af into main Mar 4, 2023
@dlqqq dlqqq deleted the fix-check-release branch March 4, 2023 00:59
@dlqqq
Copy link
Member Author

dlqqq commented Mar 4, 2023

BTW @blink1073 perhaps this could be used to simplify version-cmd in JupyterLab? 😁

dbelgrod pushed a commit to dbelgrod/jupyter-ai that referenced this pull request Jun 10, 2024
Marchlak pushed a commit to Marchlak/jupyter-ai that referenced this pull request Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant