Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capitalize variable name (github_token -> GITHUB_TOKEN) #53

Merged
merged 1 commit into from
Nov 23, 2023

Conversation

i-aki-y
Copy link
Contributor

@i-aki-y i-aki-y commented Nov 11, 2023

Since names of secrets are case-insensitive, this PR is just for styling.

In all other places, the upper case GITHUB_TOKEN is used, so I think it would be less confusing if they were unified.

Copy link

welcome bot commented Nov 11, 2023

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

Copy link
Member

@fcollonval fcollonval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @i-aki-y

@fcollonval fcollonval merged commit e926714 into jupyterlab:main Nov 23, 2023
23 checks passed
Copy link

welcome bot commented Nov 23, 2023

Congrats on your first merged pull request in this project! 🎉
congrats
Thank you for contributing, we are very proud of you! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants