Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JupyterLab 4 PyPi release #17

Closed
kevinjohncutler opened this issue Sep 21, 2023 · 5 comments
Closed

JupyterLab 4 PyPi release #17

kevinjohncutler opened this issue Sep 21, 2023 · 5 comments
Labels
enhancement New feature or request

Comments

@kevinjohncutler
Copy link

I saw the pull request got merged a while back, is the extension ready for a pypi release? I have not been able to get a local install to complete.

@kevinjohncutler kevinjohncutler added the enhancement New feature or request label Sep 21, 2023
@krassowski
Copy link
Contributor

It looks like the releaser is setup, I will try to carry out a 4.0 release.

@fcollonval
Copy link
Member

I did not release the package yet because there is an error with the icon next to the breadcrumb that is badly positioned and not accessible for click; see skipped integration test:

test.skip('should remove a favorite from breadcrumb', async ({ page }) => {

@kevinjohncutler
Copy link
Author

How badly does this affect functionality? It might be worth releasing a version with that bug if folder names still appear at the top and are clickable.

@fcollonval
Copy link
Member

Version 3.2.0 has been released with support for Lab 4: https://pypi.org/project/jupyterlab-favorites/

@kevinjohncutler
Copy link
Author

Huge thanks @fcollonval, such an improvement to my workflow (and sanity) to have this back!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants