tljh-config reload should use base url

[ikhoury]

Hey guys,

the-littlest-jupyterhub/tljh/config.py

Line 241 in f0b8745

def check_hub_ready():

This method makes a request to http://127.0.0.1:%d/hub/api and therefore does not work when the base_url is changed using c.JupyterHub.base_url. I guess this is why tljh-config reload hangs after changing the base url.

[welcome]

Thank you for opening your first issue in this project! Engagement like this is essential for open source projects! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please try to follow the issue template as it helps other other community members to contribute more effectively.

You can meet the other Jovyans by joining our Discourse forum. There is also an intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

[GeorgianaElena]

I believe you are right @ikhoury! Thanks for discovering and reporting this bug 🌻

In my opinion, the simplest way to solve this, would be to add base_url to the list of things configurable with tljh-config and use it in check_hub_ready similarly with how we're doing with http port.
I think it's a common enough use-cause to change the base url and it makes sense to make it configurable through tljh-config.
@yuvipanda, what do you think about this?

Would you like to open a PR and try to fix this @ikhoury? ❤️

[ikhoury]

Sure! Sorry for the late reply, I will work on it with a friend. I like the idea of directly using tljh-config to set the base url.