Should the idle culler also cull named servers?

[jtpio]

Testing a TLJH deployment with:

• named servers enabled (2 allowed per user)
• the idle culler service enabled

It looks like the default server is correctly culled after it has been idle for more than the number specified in timeout,

However the named servers are still shown as running in the list of servers and can be accessed normally, and they don't appear to be culled.

Should the idle culler script also take into account the named servers?

[jtpio]

Although it looks like they should be taken into account by the idle culler:

the-littlest-jupyterhub/tljh/cull_idle_servers.py

Line 197 in d0118e9

# named servers contain the 'servers' dict

[betatim]

Maybe this change to the cull idle script used by Z2JH is helpful jupyterhub/zero-to-jupyterhub-k8s#1558

[jtpio]

Thanks @betatim for the pointer!

[jtpio]

It looks like the cull_idle.py file could be copied over to TLJH.

Then adding a new remove_named_server option set to False by default that can be enabled with tljh-config.

[jtpio]

Looking into jupyterhub/zero-to-jupyterhub-k8s#1558, it seems like this change is about deleting the named server rather than stopping?

[jtpio]

Fixed by #559.