Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to aiohttp for requests in jupyterhub's cull_idle_servers #53

Open
minrk opened this issue Sep 20, 2018 · 14 comments
Open

Switch to aiohttp for requests in jupyterhub's cull_idle_servers #53

minrk opened this issue Sep 20, 2018 · 14 comments
Labels
good first issue Good for newcomers

Comments

@minrk
Copy link
Member

minrk commented Sep 20, 2018

JupyterHub uses tornado's httpclient to make requests internally. We would like to switch to using aiohttp instead.

Tasks:

  1. read cull_idle_servers.py
  2. install jupyterhub, aiohttp
  3. learn how to make requests with aiohttp
  4. find uses of AsyncHTTPClient in the script
  5. replace them with uses of aiohttp
  6. open a pull request to jupyterhub/jupyterhub with the changes

Remember, you don't need to already know how to do all this! We'll help you. Respond to the issue here if you have questions :)

@religofsil
Copy link

Hi! My name is Sasha, I'm an Outreachy applicant, and I would like to work on this task.

@minrk
Copy link
Member Author

minrk commented Sep 21, 2018

@religofsil great! Feel free to ask further questions here or on gitter. The place to start is getting set up with a local install of jupyterhub.

@minrk
Copy link
Member Author

minrk commented Oct 4, 2018

@religofsil have you made any progress on this? Feel free to stop by gitter or ask questions here if you have them. If we don't hear from you in a couple of days, we will reopen this issue so other applicants can look at it.

@kshitija08
Copy link

Hey @minrk @religofsil . If no one is taking up the issue, I would like to work on this.

@religofsil
Copy link

@minrk sorry, I was just reading the documentation on aiohttp and on asynchronous python, and got a bit lost, but I'm working on it!

@minrk
Copy link
Member Author

minrk commented Oct 8, 2018

@religofsil no problem, just checking in! Feel free to ask questions here or in Gitter.

@minrk
Copy link
Member Author

minrk commented Oct 23, 2018

@religofsil are you still working on this one? If not, I'd like to make it available to other applicants. If so, that's fine, too! Feel free to ask questions if you need help.

@religofsil
Copy link

Yes, I am! Sorry it's taking so long. :(

@minrk
Copy link
Member Author

minrk commented Oct 25, 2018

No worries! Please feel free to ask questions here or on Gitter if you get stuck.

@kshitija08
Copy link

@religofsil Hey, I would like to help in this issue. Kindly, let me know if I could work on this

@consideRatio
Copy link
Member

While the description is outdated @minrk, the issue seems relevant still. Right?

See https://github.com/jupyterhub/jupyterhub-idle-culler/blob/main/jupyterhub_idle_culler/__init__.py

@minrk
Copy link
Member Author

minrk commented Oct 11, 2022

@consideRatio that's true!

@welcome
Copy link

welcome bot commented Oct 13, 2022

Thank you for opening your first issue in this project! Engagement like this is essential for open source projects! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please try to follow the issue template as it helps other other community members to contribute more effectively.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also an intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@GeorgianaElena GeorgianaElena transferred this issue from jupyterhub/outreachy Oct 13, 2022
@GeorgianaElena
Copy link
Member

@minrk and @consideRatio, I've moved the issue in this repository to not create confusion around the this year's Outreachy projects. Plus, I believe it has more visibility here.

@GeorgianaElena GeorgianaElena added the good first issue Good for newcomers label Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

5 participants