Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests failing #115

Closed
yuvipanda opened this issue Jun 13, 2024 · 4 comments · Fixed by #119
Closed

Tests failing #115

yuvipanda opened this issue Jun 13, 2024 · 4 comments · Fixed by #119

Comments

@yuvipanda
Copy link
Contributor

The image tests are failing, but the bash is too complex for me to really debug. I think it's ok for now.

@manics
Copy link
Member

manics commented Jul 5, 2024

I don't think it's the tests, I think there's a genuine error. A clean rebuild of main leads to the desktop failing to appear, and a Javascript error Uncaught Error: Cannot find module '@novnc/novnc/core/rfb'

@manics
Copy link
Member

manics commented Jul 5, 2024

Hmmm.... maybe there are multiple errors, #120 is still failing

@consideRatio
Copy link
Member

Did a new version of websockify arrive 1 month ago perhaps? Tests fail when websockify is involved, but for both tiger and turbovnc, and in a test without this project proxying things involved.

@manics
Copy link
Member

manics commented Jul 5, 2024

I've removed websockify: #119

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants