Change port number for JUPYTERHUB_SERVICE_URL #268
Conversation
|
Thanks for submitting your first pull request! You are awesome! 🤗 |
for more information, see https://pre-commit.ci
| url = urlparse(os.environ["JUPYTERHUB_SERVICE_URL"]) | ||
| url_netloc = url.netloc.split(":") | ||
|
|
||
| if len(url_netloc) == 2: |
There was a problem hiding this comment.
This method of setting the port would lead to the new port not being set if the netloc in the original JUPYTERHUB_SERVICE_URL doesn't have the port explicitly defined (e.g. https://example.com/test wouldn't change). Meanwhile the solution in PR #267 for this issue does replace the port in all cases.
|
What's the status of this PR ? We are running into this issue and would be great if this could be merged |
consideRatio
changed the title
|
merged as #267 |
JupyterHub will add extensions to Jupyter ServerApp to configure some settings. It seems that newer versions of JupyterHub extensions will check the environment variable JUPYTERHUB_SERVICE_URL to determine the port and the base URL of the ServerApp and override the randomly generated port given in the batchspawner-singleuser.py file.
Therefore, I added some code to change the port of the JUPYTERHUB_SERVICE_URL variable before it is exported to the target machine. Since my setup uses base URL 0.0.0.0 (which is the default value), I do not need to change the base URL of the environment variable. Further modification might be needed to accommodate that.