Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add 'gres' option to SlurmSpawner #170

Merged
merged 3 commits into from
Jul 23, 2020
Merged

Conversation

Hoeze
Copy link
Contributor

@Hoeze Hoeze commented Dec 3, 2019

As the name tells, it allows to specify e.g. GPU requests

@rkdarst
Copy link
Contributor

rkdarst commented Jun 30, 2020

We could debate if we should not add a specific option for everything, since the generic req_options works, too. What do others think?

But since this is here, --gres seems to be rather important anyway (if people go more towards GPUs) so why not. I will add an entry to the changelog and add it to my integration branch.

@rkdarst
Copy link
Contributor

rkdarst commented Jul 1, 2020

I added a test, I think this is good to go.

This was referenced Jul 23, 2020
@mbmilligan
Copy link
Member

We may want to revisit the larger policy around proliferating options and requests to change defaults, but for now this seems both sufficiently generic and well-motivated to accept.

@mbmilligan mbmilligan merged commit ec5e972 into jupyterhub:master Jul 23, 2020
mbmilligan added a commit that referenced this pull request Jul 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants