Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI #226

Merged
merged 14 commits into from
Nov 23, 2023
Merged
Show file tree
Hide file tree
Changes from 13 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions .eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,7 @@ module.exports = {
extends: [
'eslint:recommended',
'plugin:@typescript-eslint/eslint-recommended',
'plugin:@typescript-eslint/recommended',
'plugin:prettier/recommended',
'prettier'
'plugin:@typescript-eslint/recommended'
],
parser: '@typescript-eslint/parser',
parserOptions: {
Expand Down
21 changes: 7 additions & 14 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,15 +24,7 @@ jobs:
extra-specs: |
python=3.9
jupyterlab=4
freecad

- name: Lint the extension
shell: bash -l {0}
run: |
set -eux
jlpm
export NODE_OPTIONS="--max-old-space-size=4096"
jlpm run lint:check
yarn=3

- name: Setup pip cache
uses: actions/cache@v2
Expand Down Expand Up @@ -70,6 +62,7 @@ jobs:
shell: bash -l {0}
run: |
set -eux
yarn install
yarn dev
jupyter labextension list 2>&1 | grep -ie "jupytercad-core.*OK"
jupyter labextension list 2>&1 | grep -ie "jupytercad-lab.*OK"
Expand Down Expand Up @@ -100,9 +93,6 @@ jobs:
runs-on: ubuntu-latest

steps:
- name: Checkout
uses: actions/checkout@v3

- name: Install Python
uses: actions/setup-python@v4
with:
Expand All @@ -120,10 +110,13 @@ jobs:
# Remove NodeJS, twice to take care of system and locally installed node versions.
sudo rm -rf $(which node)
sudo rm -rf $(which node)
pip install "jupyterlab>=4.0.0" jupytercad*.whl

cp ./jupytercad-core/dist/jupytercad*.whl ./jupytercad-lab/dist/jupytercad*.whl ./jupytercad-app/dist/jupytercad*.whl .
python -m pip install "jupyterlab>=4.0.0" jupytercad*.whl

jupyter labextension list
jupyter labextension list 2>&1 | grep -ie "jupytercad.*OK"
jupyter cad --version
# jupyterlab.browser_check will fail due to the core extension jupyterlab_pygments.
# It does not support lab v4.0.0
#python -m jupyterlab.browser_check --no-chrome-test
Expand All @@ -149,7 +142,6 @@ jobs:
extra-specs: |
python=3.9
jupyterlab=4
freecad
pythonocc-core

- name: Download extension package
Expand All @@ -161,6 +153,7 @@ jobs:
shell: bash -l {0}
run: |
set -eux
cp ./jupytercad-core/dist/jupytercad*.whl ./jupytercad-lab/dist/jupytercad*.whl ./jupytercad-app/dist/jupytercad*.whl .
python -m pip install jupytercad*.whl

- name: Install dependencies
Expand Down
18 changes: 12 additions & 6 deletions .github/workflows/check-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,12 +11,18 @@ jobs:
steps:
- name: Checkout
uses: actions/checkout@v3
- name: Base Setup
uses: jupyterlab/maintainer-tools/.github/actions/base-setup@v1
- name: Install Dependencies
run: |
pip install "jupyterlab>=4.0.0,<5"
yarn dev

- name: Install Conda environment with Micromamba
uses: mamba-org/provision-with-micromamba@main
with:
environment-name: cad
environment-file: false
channels: conda-forge/label/jupyterlab_beta,conda-forge
extra-specs: |
python=3.9
jupyterlab=4
yarn=3

- name: Check Release
uses: jupyter-server/jupyter_releaser/.github/actions/check-release@v2
with:
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/update_galata_references.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -48,14 +48,14 @@ jobs:

- name: Create the conda environment
shell: bash -l {0}
run: mamba install -q python=3.9 pip freecad jupyterlab=4.0.0 pythonocc-core
run: mamba install -q python=3.9 pip freecad jupyterlab=4 pythonocc-core

- name: Install the extension
shell: bash -l {0}
run: |
whereis python
cp ./jupytercad-core/dist/jupytercad*.whl ./jupytercad-lab/dist/jupytercad*.whl ./jupytercad-app/dist/jupytercad*.whl .
python -m pip install jupytercad*.whl
python -m pip install jupyter_collaboration==1.0.0a9

- name: Install dependencies
shell: bash -l {0}
Expand Down
2 changes: 0 additions & 2 deletions .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -51,5 +51,3 @@ repos:
- 'eslint@8.36.0'
- '@typescript-eslint/eslint-plugin@5.55.0'
- '@typescript-eslint/parser@5.55.0'
- 'eslint-plugin-prettier@5.0.1'
- 'eslint-config-prettier@8.7.0'
1 change: 0 additions & 1 deletion .prettierignore
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
node_modules
**/node_modules
**/lib
**/package.json
jupytercad
**/*.d.ts
**/*.js
Expand Down
4 changes: 2 additions & 2 deletions .readthedocs.yaml
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
version: 2

build:
os: "ubuntu-20.04"
os: 'ubuntu-20.04'
tools:
python: "mambaforge-4.10"
python: 'mambaforge-4.10'

conda:
environment: docs/environment.yml
2 changes: 1 addition & 1 deletion docs/environment.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,4 +7,4 @@ dependencies:
- pydata-sphinx-theme
- sphinx-autodoc-typehints
- pip:
- jupytercad
- jupytercad
Binary file removed examples/ArchDetail.FCStd
Binary file not shown.
Binary file removed examples/common.FCStd
Binary file not shown.
Binary file removed examples/cut.FCStd
Binary file not shown.
Binary file removed examples/example1.FCStd
Binary file not shown.
Binary file removed examples/example2.FCStd
Binary file not shown.
Binary file removed examples/example3.FCStd
Binary file not shown.
Binary file removed examples/example4.FCStd
Binary file not shown.
Binary file removed examples/example5.FCStd
Binary file not shown.
Binary file removed examples/example6.FCStd
Binary file not shown.
Binary file removed examples/example_2D.FCStd
Binary file not shown.
Loading
Loading