Restore close and shutdown confirmation dialog #7430
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
jtpio
reviewed
Jul 29, 2024
| // Shut the kernel down, without confirmation | ||
| await commands.execute('notebook:shutdown-kernel', { activate: false }); | ||
| window.close(); | ||
| const confirm = window.confirm( |
There was a problem hiding this comment.
Thanks @sai-chand04 for working on this.
As discussed in #7398, the idea was to introduce a setting to let users override the default behavior. Which does not seem to be the case here for now.
|
@sai-chand04 just checking if you are still interested in finishing the PR? Otherwise it's fine, we can try to pick it up from there and add the handling of the settings. Thanks for working on this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue: #7398
This pull request restore the close and shutdown confirmation dialog.