-
Notifications
You must be signed in to change notification settings - Fork 317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the confusing server errors during UI tests #1871
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brichet
changed the title
Fix the server errors when renaming directory or removing config file
Fix the confusing server errors during UI tests
Mar 26, 2024
Amazing -- thanks @brichet ! This is already a major improvement. Just looking quickly at the
|
Yes, some traceback are expected (test with missing file or directory). |
brichet
force-pushed
the
clean_ui-tests
branch
2 times, most recently
from
June 19, 2024 12:22
d2b9299
to
5cb7ebc
Compare
…yterlab tests and (3) remove useless notebook saving
… ready and (2) killing the kernels on teardown
AlirezaT99
pushed a commit
to AaltoSciComp/nbgrader
that referenced
this pull request
Aug 6, 2024
* Fix the server errors when renaming directory or removing config file * Clean unexpected error in assignment_list test * Should remove file exists error in create assignment and validate assignments * Try to fix windows test * Remove kernel errors in create assignment ui test, and use galata helpers * Remove kernel errors in validate assignment ui test, and use galata helpers * Fix save notebook when testing notebook application * Set the env variable in package.json instead of task.py, to simplify local tests * Fix notebook tests * Increase the doc test timeout * (1)move config creation in beforeEach, (2)fix closing notebook in jupyterlab tests and (3) remove useless notebook saving * Should remove some more traceback by (1) waiting for a notebook to be ready and (2) killing the kernels on teardown
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #1816.
It suppresses server error messages during user interface tests, which suggest that the test is not passing, and make the stdout output difficult to analyze.