-
Notifications
You must be signed in to change notification settings - Fork 317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add authentication plugin support #1093
Merged
jhamrick
merged 7 commits into
jupyter:multiple-classes-dev
from
jhamrick:add-auth-plugin
May 30, 2019
Merged
Add authentication plugin support #1093
jhamrick
merged 7 commits into
jupyter:multiple-classes-dev
from
jhamrick:add-auth-plugin
May 30, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ok, I have added some test cases but still not tested with an actual JupyterHub instance but will try to do that next. FYI, to use the JupyterHub auth, you would set the following in your
|
Confirmed that this works with jupyterhub assuming you provide the correct config. Here's what I used:
|
This was referenced Jun 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the JupyterHub auth support for determining whether a student has access to a particular class into a special plugin class.
Authenticator
object which has methods for determining which classes a student has access to, as well as for adding and removing students from access groups.Authenticator
object, which is by default to have no authentication but there is also the option to use JupyterHub groups authentication, which uses the logic from Restrict access for students to different courses #1040Authenticator
object is passed around much like theCourseDirectory
is so that the same object can be shared by multiple high-level nbgrader components.cc @sigurdurb @damianavila @psychemedia @BertR
I will add docs and tests tomorrow. I also need to check that I haven't broken the JupyterHub auth.