Replies: 33 comments 2 replies
-
Thanks @brichet for starting this!
It would also be great to take the opportunity to rename the |
Beta Was this translation helpful? Give feedback.
-
It looks like there is already a @BertR or anyone else recently active, do you know if there was a plan to make a If so, maybe we'll want to make the release before branching and continuing further work as mentioned in the comment above? |
Beta Was this translation helpful? Give feedback.
-
cc @jhamrick who might also know about a previous 0.7.0 release plan. |
Beta Was this translation helpful? Give feedback.
-
Thanks @jtpio, I had not seen that |
Beta Was this translation helpful? Give feedback.
-
IIRC, the main plan for 0.7.0 was to fix the breakage with nbconvert (which I started with #1421 but was unable to complete). I think doing effectively a maintenance release for 0.7.0 that fixes that breakage (and any others that might have popped up) would be fantastic, and then do a subsequent release that does the update for JupyterLab extensions could make sense---then there's one final release with up-to-date dependencies without JupyterLab, and a second release that does the migration to JupyterLab. Thanks so much to everyone working on this, it's fantastic to see some progress towards this 😄 |
Beta Was this translation helpful? Give feedback.
-
Actually looking into things a bit more, I am now reminded that there's been a lot of work for 0.7.0 and #1421 was basically the last blocking thing---so I would definitely recommend doing that fix, then releasing 0.7.0, then starting the new functionality for 0.8.0. I'll update the labels for various PRs to make it clearer that everything merged so far should be for the 0.7.0 release... |
Beta Was this translation helpful? Give feedback.
-
@jhamrick #1567 was merged yesterday to fix the breakage with nbconvert. It should have start from #1421 but it seems that I didn't seen how advanced it was. |
Beta Was this translation helpful? Give feedback.
-
I renamed the issue to 0.8 release plan as the 0.7 already exists. |
Beta Was this translation helpful? Give feedback.
-
Fantastic, thanks! Yeah I initially missed #1567 too but really glad you were able to get it fixed. Exciting to see things moving forward 😄 |
Beta Was this translation helpful? Give feedback.
-
I am not sure, but perhaps it is worth trying to resolve #1557 for 0.7 as well? Just wanted to flag it as I noticed it caused the tests to break as well. |
Beta Was this translation helpful? Give feedback.
-
The tests pass on my side with python 3.8 and 3.9, and |
Beta Was this translation helpful? Give feedback.
-
Ah that's great. We should be able to do it with dependabot commands. |
Beta Was this translation helpful? Give feedback.
-
So as a summary, how about the following?
Maybe 0.7.0 can be released manually as before. And we switch to the releaser (#1570) for 0.8.0? |
Beta Was this translation helpful? Give feedback.
-
Sounds like a good plan to me! |
Beta Was this translation helpful? Give feedback.
-
I created #1573 to prepare the 0.7.0 release. I will try to actually make the release tomorrow, though I am not 100% sure I'll have the time. If not, feel free to go ahead and do the release in my absence @jtpio (basically after this PR is merged following all steps from https://nbgrader.readthedocs.io/en/stable/contributor_guide/releasing.html#clean-all-untracked-files onwards). |
Beta Was this translation helpful? Give feedback.
-
A first |
Beta Was this translation helpful? Give feedback.
-
Sure, sounds good to me. Perhaps it's also worth doing a release for 0.7.1 now too... I can do the 0.7.1 release and feel free to go ahead with the 0.8.0a0 pre-release. |
Beta Was this translation helpful? Give feedback.
-
Looking into it with the Jupyter Releaser. |
Beta Was this translation helpful? Give feedback.
-
The first Try it with |
Beta Was this translation helpful? Give feedback.
-
Thanks @jtpio. |
Beta Was this translation helpful? Give feedback.
-
It seems that the labextension published with the package kept the version |
Beta Was this translation helpful? Give feedback.
-
Ah thanks @brichet for catching this. For reference here is the log of the Full Release run: https://github.com/jtpio/jupyter_releaser/runs/7090980402?check_suite_focus=true A guess would be that it's because the extension was built during the setup step, which produced the static assets for the prebuilt extension. And later the extension build would be skipped because of the For notebook we use this releaser hook to make sure to start from a clean state before building the Python wheel and sdist, which is probably related iirc: |
Beta Was this translation helpful? Give feedback.
-
There is already something similar in nbgrader which clean the Lines 104 to 106 in 09e632b |
Beta Was this translation helpful? Give feedback.
-
Ah ok then maybe it's just because this hook defined in Lines 19 to 20 in 09e632b If there is already some releaser configuration in We should keep the configuration in one place only, for example |
Beta Was this translation helpful? Give feedback.
-
You're right, it's necessarily better to keep all the hooks in only one place. |
Beta Was this translation helpful? Give feedback.
-
Pre-release 0.8.0a2 is out, |
Beta Was this translation helpful? Give feedback.
-
The release can also be tested on https://mybinder.org/v2/gh/jupyter/nbgrader.git/main |
Beta Was this translation helpful? Give feedback.
-
Version Installation : Binder : https://mybinder.org/v2/gh/jupyter/nbgrader.git/v0.8.0 |
Beta Was this translation helpful? Give feedback.
-
Really nice, thanks @brichet and everyone who contributed! |
Beta Was this translation helpful? Give feedback.
-
Is there going to be a blog post or other announcement about this release to share? |
Beta Was this translation helpful? Give feedback.
-
This is an issue for 0.8 release plan, to port nbgrader extensions to notebook 7
Classic notebook extensions system and notebook 7 extensions system (labextension) are not compatibles.
Consequently, the first step would be to move the current master branch to a 0.7.x branch (a branch which keep compatibility with Classic Notebook), and use the master branch for 0.8 release (compatible with Notebook 7 and Jupyterlab).
That 0.8 release would have the following steps :
master
branch to0.7.x
branchmaster
branch tomain
Beta Was this translation helpful? Give feedback.
All reactions