Replace <p> inside <a> with <span> and <small> for valid HTML #804
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
choldgraf
approved these changes
Jun 19, 2025
There was a problem hiding this comment.
This looks correct to me - it's generally not recommended to put block-level elements inside <a> tags so I think this is a correct improvement. This page needs some other work on the style side but I think this PR is still an improvement so I'll merge!
Thanks for the contribution!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HTML does not allow a
<p>tag directly inside an<a>tag. This change replaces<p>with<span>and<small>elements to maintain semantic structure and ensure valid, accessible HTML.