Skip to content

Fix CI by removing <a> and <button> nesting as well as ignoring some working links #789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 9, 2025
Merged

Fix CI by removing <a> and <button> nesting as well as ignoring some working links #789

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fb39d51
Nest a inside button
choldgraf Apr 9, 2025
71fcc98
Add ignore rules for link check
choldgraf Apr 9, 2025
f3e70b9
Removing the use of buttons entirely
choldgraf Apr 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Nest a inside button
  • Loading branch information
@choldgraf
choldgraf committed Apr 9, 2025
commit fb39d51a17c60e04579d6d091da1108b37d44682
11 changes: 7 additions & 4 deletions assets/css/main.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,15 +152,18 @@
max-width: 500px;
}

.con-button button {
button.con-button {
background-color: #f37726;
color: white;

a {
color: white;
font-size: 1em;
font-weight: 600;
}
margin: 0 .5em;
padding: 1em;
border-radius: 5px;
border: none;
font-size: 1em;
font-weight: 600;
cursor: pointer;
}

Expand Down
4 changes: 2 additions & 2 deletions index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,8 +256,8 @@
<div class="con-program">
<p>San Diego, California</p>
</div>
<a class="con-button" href="https://events.linuxfoundation.org/jupytercon/"><button>Conference Website</button></a>
<a class="con-button" href="https://events.linuxfoundation.org/jupytercon/program/cfp/"><button>Call for Proposals</button></a>
<button class="con-button"><a href="https://events.linuxfoundation.org/jupytercon/">Conference Website</a></button>
<button class="con-button"><a href="https://events.linuxfoundation.org/jupytercon/program/cfp/">Call for Proposals</a></button>
</div>
</div>
</div>
Expand Down
Loading