Skip to content

Remove mamba pin for aarch64 #1593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 2, 2022
Merged

Remove mamba pin for aarch64 #1593

merged 1 commit into from
Feb 2, 2022

Conversation

maresb
Copy link
Contributor

@maresb maresb commented Feb 2, 2022

Closes #1539

@mathbunnyru
Copy link
Member

Let's indeed try this out, thank you!

@consideRatio
Copy link
Member

Let's hope for the best! Thanks @maresb !!!

@maresb
Copy link
Contributor Author

maresb commented Feb 2, 2022

I'm trying to follow along in the workflow logs, but I'm confused. There are two workflows:

  • Build, test, and publish Docker Images
  • Build and test amd64 Docker Images

This seems redundant. Is the point that QEMU is slow so that you can save time by testing without, but you want the publishing workflow to be uniform across all platforms?

@mathbunnyru
Copy link
Member

Yes, slow build times under QEMU is the reason.
Most of the PRs are enough to be tested under x86_64 only, that's why I implemented a separate workflow.
If a feature is similar for arm and x86 or for x86 only, we can skip long tests and merge PRs faster.

@maresb
Copy link
Contributor Author

maresb commented Feb 2, 2022

Green!!! 🎉

@consideRatio consideRatio merged commit 27c294a into jupyter:master Feb 2, 2022
@consideRatio
Copy link
Member

Wieeeee!!!! ❤️ 🎉 🚀

@maresb maresb deleted the patch-1 branch February 2, 2022 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build is stuck for jupyter/scipy-notebook arm64 image
3 participants