Skip to content

Commit 5ea1adb

Browse files
committed
Improve Dockerfiles codestyle
1 parent 7f8cdf8 commit 5ea1adb

File tree

8 files changed

+18
-18
lines changed

8 files changed

+18
-18
lines changed

images/base-notebook/Dockerfile

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -31,18 +31,18 @@ RUN apt-get update --yes && \
3131

3232
USER ${NB_UID}
3333

34-
# Install JupyterLab, Jupyter Notebook, JupyterHub and NBClassic
34+
# Install JupyterHub, JupyterLab, NBClassic and Jupyter Notebook
3535
# Generate a Jupyter Server config
3636
# Cleanup temporary files
3737
# Correct permissions
3838
# Do all this in a single RUN command to avoid duplicating all of the
3939
# files across image layers when the permissions change
4040
WORKDIR /tmp
4141
RUN mamba install --yes \
42-
'jupyterlab' \
43-
'notebook' \
4442
'jupyterhub' \
45-
'nbclassic' && \
43+
'jupyterlab' \
44+
'nbclassic' \
45+
'notebook' && \
4646
jupyter server --generate-config && \
4747
mamba clean --all -f -y && \
4848
npm cache clean --force && \

images/docker-stacks-foundation/Dockerfile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -117,9 +117,9 @@ RUN set -x && \
117117
--root-prefix="${CONDA_DIR}" \
118118
--prefix="${CONDA_DIR}" \
119119
--yes \
120-
"${PYTHON_SPECIFIER}" \
120+
'jupyter_core' \
121121
'mamba' \
122-
'jupyter_core' && \
122+
"${PYTHON_SPECIFIER}" && \
123123
rm -rf /tmp/bin/ && \
124124
# Pin major.minor version of python
125125
# https://conda.io/projects/conda/en/latest/user-guide/tasks/manage-pkgs.html#preventing-packages-from-updating-pinning

images/pytorch-notebook/Dockerfile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ SHELL ["/bin/bash", "-o", "pipefail", "-c"]
1515
# hadolint ignore=DL3013
1616
RUN pip install --no-cache-dir --index-url 'https://download.pytorch.org/whl/cpu' \
1717
'torch' \
18-
'torchvision' \
19-
'torchaudio' && \
18+
'torchaudio' \
19+
'torchvision' && \
2020
fix-permissions "${CONDA_DIR}" && \
2121
fix-permissions "/home/${NB_USER}"

images/pytorch-notebook/cuda11/Dockerfile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,8 @@ SHELL ["/bin/bash", "-o", "pipefail", "-c"]
1515
# hadolint ignore=DL3013
1616
RUN pip install --no-cache-dir --extra-index-url=https://pypi.nvidia.com --index-url 'https://download.pytorch.org/whl/cu118' \
1717
'torch' \
18-
'torchvision' \
19-
'torchaudio' && \
18+
'torchaudio' \
19+
'torchvision' && \
2020
fix-permissions "${CONDA_DIR}" && \
2121
fix-permissions "/home/${NB_USER}"
2222

images/pytorch-notebook/cuda12/Dockerfile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,8 @@ SHELL ["/bin/bash", "-o", "pipefail", "-c"]
1515
# hadolint ignore=DL3013
1616
RUN pip install --no-cache-dir --extra-index-url=https://pypi.nvidia.com --index-url 'https://download.pytorch.org/whl/cu121' \
1717
'torch' \
18-
'torchvision' \
19-
'torchaudio' && \
18+
'torchaudio' \
19+
'torchvision' && \
2020
fix-permissions "${CONDA_DIR}" && \
2121
fix-permissions "/home/${NB_USER}"
2222

images/scipy-notebook/Dockerfile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ RUN mamba install --yes \
3838
'dask' \
3939
'dill' \
4040
'h5py' \
41-
'ipympl'\
41+
'ipympl' \
4242
'ipywidgets' \
4343
'jupyterlab-git' \
4444
'matplotlib-base' \
@@ -56,7 +56,7 @@ RUN mamba install --yes \
5656
'sqlalchemy' \
5757
'statsmodels' \
5858
'sympy' \
59-
'widgetsnbextension'\
59+
'widgetsnbextension' \
6060
'xlrd' && \
6161
mamba clean --all -f -y && \
6262
fix-permissions "${CONDA_DIR}" && \

images/tensorflow-notebook/Dockerfile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,8 @@ SHELL ["/bin/bash", "-o", "pipefail", "-c"]
1414
# Install tensorflow with pip, on x86_64 tensorflow-cpu
1515
RUN [[ $(uname -m) = x86_64 ]] && TF_POSTFIX="-cpu" || TF_POSTFIX="" && \
1616
pip install --no-cache-dir \
17-
"tensorflow${TF_POSTFIX}" \
18-
"jupyter-server-proxy" && \
17+
"jupyter-server-proxy" \
18+
"tensorflow${TF_POSTFIX}" && \
1919
fix-permissions "${CONDA_DIR}" && \
2020
fix-permissions "/home/${NB_USER}"
2121

images/tensorflow-notebook/cuda/Dockerfile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,8 @@ SHELL ["/bin/bash", "-o", "pipefail", "-c"]
1313

1414
# Install TensorFlow, CUDA and cuDNN with pip
1515
RUN pip install --no-cache-dir \
16-
"tensorflow[and-cuda]" \
17-
"jupyter-server-proxy" && \
16+
"jupyter-server-proxy" \
17+
"tensorflow[and-cuda]" && \
1818
fix-permissions "${CONDA_DIR}" && \
1919
fix-permissions "/home/${NB_USER}"
2020

0 commit comments

Comments
 (0)