Skip to content

Commit 4c12832

Browse files
committed
fix duplicate and hardcoded value in makefile
1 parent 03ec0a5 commit 4c12832

File tree

1 file changed

+3
-6
lines changed

1 file changed

+3
-6
lines changed

Makefile

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -69,10 +69,10 @@ n-other-diff: ## number of files outside docs/ changed since branch from master
6969
@git diff --name-only $(DIFF_RANGE) -- ':!docs/' | wc -l | awk '{print $$1}'
7070

7171
run/%: ## run a bash in interactive mode in a stack
72-
docker run -it --rm jupyter/$(notdir $@) /bin/bash
72+
docker run -it --rm $(OWNER)/$(notdir $@) $(SHELL)
7373

7474
run-sudo/%: ## run a bash in interactive mode as root in a stack
75-
docker run -it --rm -u root jupyter/$(notdir $@) /bin/bash
75+
docker run -it --rm -u root $(OWNER)/$(notdir $@) $(SHELL)
7676

7777
tx-en: ## rebuild en locale strings and push to master (req: GH_TOKEN)
7878
@git config --global user.email "travis@travis-ci.org"
@@ -93,7 +93,4 @@ test/%: ## run tests against a stack
9393
@TEST_IMAGE="$(OWNER)/$(notdir $@)" pytest test
9494

9595
test/base-notebook: ## test supported options in the base notebook
96-
@TEST_IMAGE="$(OWNER)/$(notdir $@)" pytest test base-notebook/test
97-
98-
up/%: ## launch a stack
99-
docker run --rm -p 8888:8888 jupyter/$(notdir $@)
96+
@TEST_IMAGE="$(OWNER)/$(notdir $@)" pytest test base-notebook/test

0 commit comments

Comments
 (0)