switched prompt arguments to use copy by reference

Author: staxfur

cpp-terminal/prompt.cpp

@@ -5,10 +5,10 @@
 #include "private/conversion.hpp"
 #include "private/platform.hpp"
 
-Term::Result Term::prompt_blocking(std::string message,
-                                   std::string first_option,
-                                   std::string second_option,
-                                   std::string prompt_indicator) {
+Term::Result Term::prompt_blocking(const std::string& message,
+                                   const std::string& first_option,
+                                   const std::string& second_option,
+                                   const std::string& prompt_indicator) {
     Terminal term(false, true, true);
     std::cout << message << " [" << first_option << '/' << second_option << ']'
               << prompt_indicator << ' ' << std::flush;
@@ -65,10 +65,10 @@ Term::Result Term::prompt_blocking(std::string message,
     return Result::ERROR;
 }
 
-Term::Result Term::prompt_non_blocking(std::string message,
-                                       std::string first_option,
-                                       std::string second_option,
-                                       std::string prompt_indicator) {
+Term::Result Term::prompt_non_blocking(const std::string& message,
+                                       const std::string& first_option,
+                                       const std::string& second_option,
+                                       const std::string& prompt_indicator) {
     Terminal term(false, true, true);
     std::cout << message << " [" << first_option << '/' << second_option << ']'
               << prompt_indicator << ' ' << std::flush;

cpp-terminal/prompt.hpp

@@ -23,17 +23,17 @@ enum class Result_simple { YES, NO, ABORT };
 
 // A simple yes/no prompt, requires the user to press the ENTER key to continue
 // The arguments are used like this: 1 [2/3]4 <user Input>
-Result prompt_blocking(std::string message,
-                       std::string first_option,
-                       std::string second_option,
-                       std::string prompt_indicator);
+Result prompt_blocking(const std::string& message,
+                       const std::string& first_option,
+                       const std::string& second_option,
+                       const std::string& prompt_indicator);
 
 // A simple yes/no prompt, returns immediately after the first key press
 // The arguments are used like this: 1 [2/3]4 <user Input>
-Result prompt_non_blocking(std::string message,
-                           std::string first_option,
-                           std::string second_option,
-                           std::string prompt_indicator);
+Result prompt_non_blocking(const std::string& message,
+                           const std::string& first_option,
+                           const std::string& second_option,
+                           const std::string& prompt_indicator);
 
 // The most simple prompt possible, requires the user to press enter to continue
 // The arguments are used like this: 1 [y/N]: