Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for use with Jupyter Releaser #81

Merged
merged 1 commit into from
Oct 11, 2021

Conversation

davidbrochart
Copy link
Collaborator

Closes #70

@davidbrochart
Copy link
Collaborator Author

This last commit prepares fps-auth for use with Jupyter Releaser, but I'm not sure that's the way to go. In particular, I'm wondering if we will have a global jupyverse release that will also release all the plugins, or if jupyverse and each plugin will be released independently. In the former case, that would mean whenever there is a change in jupyverse or in one of the its plugins, all plugins will be released even if they don't change. In the later case, I'm wondering if it makes sense to have the plugins in this repo then, or each one in their own repo.

@jtpio
Copy link
Member

jtpio commented Oct 1, 2021

wondering if we will have a global jupyverse release that will also release all the plugins, or if jupyverse and each plugin will be released independently

This sounds similar to JavaScript monorepos, with the tradeoff between managing each package independently (in its own repo) vs in a monorepo.

Probably the plugins could still live in the same repo. The bump version script could check whether a plugin has changed and bump the version accordingly. Or all plugins follow the same cycle for patch and build increments, and are versioned independently for minor and major bumps (that might be simpler).

@davidbrochart davidbrochart force-pushed the jupyter_releaser branch 2 times, most recently from 7161693 to f1e69c2 Compare October 11, 2021 12:26
@davidbrochart
Copy link
Collaborator Author

I'm going to merge this PR, even though the "Check Release" actions fail, and iterate on jupyter-server/jupyter_releaser#176 until we get Jupyter Releaser to work on this repo.

@davidbrochart davidbrochart marked this pull request as ready for review October 11, 2021 13:52
@davidbrochart davidbrochart merged commit 8003fb6 into jupyter-server:main Oct 11, 2021
@davidbrochart davidbrochart deleted the jupyter_releaser branch October 11, 2021 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adopt the Jupyter Releaser
2 participants