Remove Podman specific runArgs
#208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidbrochart
approved these changes
Aug 15, 2022
|
It's working now. If you click the green button on the main page for the repo (the one usually used for getting the http/ssh clone url) there's a codespaces tab, then "Create codespace on main" opens a new instance. Wait a minute or so for the dependencies/extensions to get installed and it's ready to go 🎉 |
|
Hmmm for me it hangs on "Connecting...", do you know what could be the issue? |
|
So it works when I choose to open the codespace in VS Code Desktop, but not in the browser. |
|
Hmm odd, I'm not sure why it's not working for you in the browser. You can try going to https://github.com/jupyter-server/jupyverse/codespaces, deleting any existing environments, and creating a new one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #207 was merged I went to check if codespaces were working and there was an error as I left a podman-only command run argument in the configuration.
In the docs it's recommended to use this configuration when running with rootless podman, but it isn't compatible with docker, which most people (and the online based codespaces) use, so this patch comments it out and adds an explanation.