Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation update #193

Merged
merged 5 commits into from
Jul 24, 2022
Merged

Documentation update #193

merged 5 commits into from
Jul 24, 2022

Conversation

photocyte
Copy link
Contributor

Hi there,

Just some simple documentation updates regarding installation. See the commit messages for the rationale for the exact changes.

All the best,
-Tim

Add quotes to pip install as zsh seems to not like the unquoted square brackets
Use the to-become-standard mamba execution via conda rather than mamba executable itself
@welcome
Copy link

welcome bot commented Jul 18, 2022

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

Copy link
Collaborator

@davidbrochart davidbrochart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @photocyte!
Let's directly use mamba instead of conda with libmamba.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
photocyte and others added 3 commits July 21, 2022 21:04
Co-authored-by: David Brochart <david.brochart@gmail.com>
Co-authored-by: David Brochart <david.brochart@gmail.com>
Co-authored-by: David Brochart <david.brochart@gmail.com>
@davidbrochart davidbrochart merged commit a5f8f79 into jupyter-server:main Jul 24, 2022
@welcome
Copy link

welcome bot commented Jul 24, 2022

Congrats on your first merged pull request in this project! 🎉
congrats
Thank you for contributing, we are very proud of you! ❤️

@davidbrochart
Copy link
Collaborator

Thanks @photocyte !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants