Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support embedding in iframes, perhaps via custom/custom.js #284

Open
ajbouh opened this issue Apr 5, 2023 · 1 comment
Open

support embedding in iframes, perhaps via custom/custom.js #284

ajbouh opened this issue Apr 5, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@ajbouh
Copy link

ajbouh commented Apr 5, 2023

Description

Based on https://jupyter-notebook.readthedocs.io/en/stable/public_server.html#embedding-the-notebook-in-another-website

One must add a custom/custom.js file to $JUPYTER_CONFIG_DIR:

define(['base/js/namespace'], function (Jupyter) {
  Jupyter._target = '_self';
});

Based on my initial experiments, it doesn't seem like this file is being included by Jupyverse into the served frontend. Is the expected? Intended?

The core thing I'm trying to do is use my jupyverse instance from within an iframe. Trying to use the above approach may be a dead-end. I'd be just as happy to do something else, like set a proper "url prefix" to use when opening links/new tabs from places like /retro/tree.

@ajbouh ajbouh added the bug Something isn't working label Apr 5, 2023
@welcome
Copy link

welcome bot commented Apr 5, 2023

Thank you for opening your first issue in this project! Engagement like this is essential for open source projects! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please try to follow the issue template as it helps other other community members to contribute more effectively.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also an intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant