Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to pass string as a shell override #42

Merged
merged 1 commit into from
Sep 8, 2022

Conversation

krassowski
Copy link
Contributor

Relates to jupyterlab/jupyterlab#12540.

I think that for many users passing a sting may be more convenient and for majority (if not all) shlex.split should do the job well.

It will require a follow up PR in jupyter_server to change:

terminado_settings = Dict(List())

(once jupyter-server/jupyter_server#949 gets merged) into

terminado_settings = Dict(Union(List(), Unicode()))

@welcome
Copy link

welcome bot commented Sep 8, 2022

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@blink1073 blink1073 added the enhancement New feature or request label Sep 8, 2022
@blink1073 blink1073 merged commit 6d8b60b into jupyter-server:main Sep 8, 2022
@welcome
Copy link

welcome bot commented Sep 8, 2022

Congrats on your first merged pull request in this project! 🎉
congrats
Thank you for contributing, we are very proud of you! ❤️

@krassowski krassowski deleted the shlex-split-override branch September 8, 2022 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants