Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

init_httpserver at the end of initialize #517

Merged
merged 1 commit into from
May 13, 2021

Conversation

minrk
Copy link
Contributor

@minrk minrk commented May 13, 2021

init_httpserver references IOLoop.current()

If a server extension sets an asyncio EventLoopPolicy, any prior reference to IOLoop.current or asyncio.get_event_loop() will be invalidated.

We should try to avoid this during intialize at all, or at least until the very end.

Arguably, the http server listen should occur in .start()

There is one other reference to the loop in terminado: jupyter/terminado#102

init_httpserver references IOLoop.current()

If a server extension sets an asyncio EventLoopPolicy, any prior reference to IOLoop.current or asyncio.get_event_loop() will be invalidated.

We should try to avoid this during intialize at all, or at least until the very end.

Arguably, the http server listen should occur in `.start()`
@codecov-commenter
Copy link

codecov-commenter commented May 13, 2021

Codecov Report

Merging #517 (9cf60d9) into master (f5b3b2d) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #517   +/-   ##
=======================================
  Coverage   77.08%   77.08%           
=======================================
  Files         107      107           
  Lines        9500     9500           
  Branches     1029     1029           
=======================================
  Hits         7323     7323           
  Misses       1807     1807           
  Partials      370      370           
Impacted Files Coverage Δ
jupyter_server/serverapp.py 67.23% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5b3b2d...9cf60d9. Read the comment docs.

@Zsailer Zsailer merged commit 15417ff into jupyter-server:master May 13, 2021
@minrk minrk deleted the delay-httpserver branch May 14, 2021 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants