Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Implement jupyter server listextensions #151

Closed

Conversation

echarles
Copy link
Member

@echarles echarles commented Dec 4, 2019

This PR implement the extensions listing as a subapp of jupyter server.

@vidartf
Copy link
Member

vidartf commented Dec 9, 2019

So, where we previously did jupyter serverextension list, we now do jupyter listextensions? What about the install commands?

@echarles
Copy link
Member Author

echarles commented Dec 9, 2019

Hi @vidartf , This implements jupyter server listextensions instead of jupyter serverextension list.

The last one is still supported for backwards compatibility reasons. This PR is just a first shot further to a discussion I had with @Zsailer. We said we would further see how we should progress with that.

I have added a WIP to the title as we first need to define how we progress, especially on how we can make a distinction between the classical extensions and the new application extensions. I expect confusion for users and even developers...

@echarles echarles changed the title Implement jupyter server listextensions [WIP] Implement jupyter server listextensions Dec 9, 2019
@dhirschfeld
Copy link
Contributor

listextensions seems a bit awkward and unnatural - it's not an actual word itself but a concatenation of two separate words.

Granted, the same could be said about serverextension but somehow it seems even worse. Maybe it's the combination of the verb and noun together instead of jupyter thing action it's jupyter thing action-on-sub-thing i.e. it's trying to cram a 3-level hierarchy into only two levels by conflating the last level with the action you want to perform on it.

i.e. jupyter has a server which in turn has extensions for which you want to perform actions such as list. Whilst a mouthful, I think the below might be a better api:

jupyter server extension list

If there are more actions that you want to support (install/remove/enable/disable?) then the above seems more composable than jupyter server installextension etc...

@rolweber
Copy link
Contributor

rolweber commented Dec 9, 2019

If it is a technical problem to pass three command words instead of two, either of these would be more readable:

  • jupyter server-extension list
  • jupyter server extension-list

@Zsailer
Copy link
Member

Zsailer commented Dec 9, 2019

I agree with the comments above. I've opened a #157 as an alternative approach, implementing a jupyter server extension ... subcommand syntax.

@echarles
Copy link
Member Author

echarles commented Dec 9, 2019

Closing this in favor of #157

@echarles echarles closed this Dec 9, 2019
Zsailer pushed a commit to Zsailer/jupyter_server that referenced this pull request Nov 18, 2022
* wip

* update deps and add comment

* wip add react components

* add styling

* more updates

* clean up

* finish component
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants