Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(no action need know, set issue for further tracking) Jump definition doesn't work with lsp_symlink #1097

Open
linlol opened this issue Sep 12, 2024 · 2 comments

Comments

@linlol
Copy link

linlol commented Sep 12, 2024

Description

On our end, we have our notebooks in one mounted folder (denoted as /mount)

While our lib is installed in home folder (/home/user)

In this case, lsp works if I create lsp client and server within a notebook

(I just create lsp server via PythonLSPServer in sub process without any other args except std I/O)

However, when I try to navigate the definition with extension, websocket just returns nothing and I got error then

Is it expected or shall I make any additional config? On my case my code and lib are placed at different filesystem and I create symlink across them, not sure if it would access any corener case

Context

  • Operating System and version:
  • Browser and version:
  • JupyterLab version:
  • Language server and version:
Required: installed server extensions
Paste the output from running `jupyter server extension list` from the command line here.
You may want to sanitize the paths in the output.
Required: installed lab extensions
Paste the output from running `jupyter labextension list` from the command line here.
You may want to sanitize the paths in the output.
Troubleshoot Output
Paste the output from running `jupyter troubleshoot` from the command line here.
You may want to sanitize the paths in the output.
Command Line Output
Paste the output from your command line running `jupyter lab` here, use `--debug` if possible.
Browser Output (recommended for all interface issues)
Paste the output from your browser JavaScript console replacing the text in here.

To learn how to open the developer tools in your browser:
https://developer.mozilla.org/en-US/docs/Learn/Common_questions/What_are_browser_developer_tools#How_to_open_the_devtools_in_your_browser
If too many messages accumulated after many hours of working in JupyterLab,
consider refreshing the window and then reproducing the bug to reduce the noise in the logs.

@linlol
Copy link
Author

linlol commented Sep 12, 2024

Feel sorry that since it is internal system and I cannot login GitHub on working environment

Please let me know if you want any further info

@linlol
Copy link
Author

linlol commented Sep 13, 2024

take a further look today, PythonLSPServer shall be good, as if I send text decinition rpc msg to server directly, it works

Looks like in LanguageServerManager.on_client_message function doesn't reply?

@linlol linlol changed the title Jump definition doesn't work with lsp_symlink (no action need know, set issue for further tracking) Jump definition doesn't work with lsp_symlink Sep 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant