Skip to content

Commit fc21aef

Browse files
committed
Fix completion provider isApplicable() for Console
1 parent ace7047 commit fc21aef

File tree

2 files changed

+8
-0
lines changed

2 files changed

+8
-0
lines changed

packages/jupyterlab-lsp/src/features/completion/overrides.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -92,6 +92,10 @@ export class EnhancedKernelCompleterProvider extends KernelCompleterProvider {
9292
}
9393

9494
const manager = this.options.connectionManager;
95+
if (!context.widget.hasOwnProperty('path')) {
96+
// there is no path for Console as it is not a DocumentWidget
97+
return upstream;
98+
}
9599
const widget = context.widget as IDocumentWidget;
96100
const adapter = manager.adapters.get(widget.context.path);
97101

packages/jupyterlab-lsp/src/features/completion/provider.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -300,6 +300,10 @@ export class CompletionProvider implements ICompletionProvider<CompletionItem> {
300300
return false;
301301
}
302302
const manager = this.options.connectionManager;
303+
if (!context.widget.hasOwnProperty('path')) {
304+
// there is no path for Console as it is not a DocumentWidget
305+
return false;
306+
}
303307
const widget = context.widget as IDocumentWidget;
304308
const adapter = manager.adapters.get(widget.context.path);
305309
if (!adapter) {

0 commit comments

Comments
 (0)