Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add client and kernel coverage from robot tests #89

Merged
merged 10 commits into from
May 24, 2023

Conversation

nrbgt
Copy link
Contributor

@nrbgt nrbgt commented May 19, 2023

Checklist

  • the PR target is correct
    • main for releases, docs-only fixes and post-release hot-fixes
    • dev for everything else
  • ran doit lint locally

References

Code changes

  • add python-dotenv
  • do instrumented build when TOTAL_COVERAGE is set
  • gather coverage from browser during robot tests
  • run kernels with coverage
  • generate atest only and combined (atest + utest) coverage
  • run full suite under coverage in CI

User-facing changes

n/a

Backwards-incompatible changes

n/a

Screens

note screen
combined py image
js image

@github-actions
Copy link

Try it on ⬅️ ReadTheDocs or Binder ➡️

Copy link
Contributor

@sanbales sanbales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did a quick pass over the code changes. Looked good to me.

@nrbgt nrbgt marked this pull request as ready for review May 23, 2023 17:45
@nrbgt nrbgt requested review from sanbales and dfreeman06 May 23, 2023 18:40
Copy link
Contributor

@sanbales sanbales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! I'm on travel without much of a chance to do a thorough review, but tests are passing and changes look good.

@nrbgt nrbgt merged commit 17068b3 into jupyrdf:dev May 24, 2023
@nrbgt nrbgt deleted the gh-88-atest-coverage branch May 24, 2023 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants