Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow LauncherInterceptors to be discovered when the launcher is used as a Java module #3562

Merged
merged 1 commit into from
Nov 20, 2023

Conversation

shartte
Copy link
Contributor

@shartte shartte commented Nov 19, 2023

Overview

Fixes #3561 by including the new LauncherInterceptor service in the module metadata for the launcher JPMS module.
Otherwise in the context of Java Modules, it cannot use ServiceLoader to look up implementations of LauncherInterceptor.


I hereby agree to the terms of the JUnit Contributor License Agreement.


Definition of Done

  • There are no TODOs left in the code
  • Method preconditions are checked and documented in the method's Javadoc
  • Coding conventions (e.g. for logging) have been followed
  • Change is covered by automated tests including corner cases, errors, and exception handling (NOTE: I do not think there are automated tests for JPMS Found a test that checks for the module declarations and adapted it)
  • Public API has Javadoc and @API annotations
  • Change is documented in the User Guide and Release Notes

@sbrannen sbrannen changed the title Fix LauncherInterceptor when the launcher is used as a Java module Allow LauncherInterceptors to be discovered when the launcher is used as a Java module Nov 19, 2023
Copy link
Member

@sormuras sormuras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch and fix!
Including the addition of LauncherSessionListener to the module API documentation.

@sormuras sormuras merged commit 8d0deb0 into junit-team:main Nov 20, 2023
12 checks passed
@marcphilipp marcphilipp added this to the 5.10.2 milestone Nov 20, 2023
@sbrannen sbrannen removed this from the 5.10.2 milestone Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LauncherInterceptor is missing from the org.junit.platform.launcher module's uses declaration
4 participants