junit5/surefire: testcase names issue

[NicoLaval]

Hi,

I'm using Junit Jupiter 5 and surefire to run my Java tests (Java 17).
I didn't succeed to inject displayName in my surefire report:

  <testcase name="dynamicTestsFromCollection()[1]" classname="my_package" time="0.0"/>
  <testcase name="dynamicTestsFromCollection()[2]" classname="my_package" time="0.0"/>
  <testcase name="dynamicTestsFromCollection()[3]" classname="my_package" time="0.0"/>

Here is my Java test class:

class MyTest {

    @TestFactory
    Collection<DynamicTest> dynamicTestsFromCollection() {
        return Arrays.asList(
                DynamicTest.dynamicTest("1st dynamic test", () -> assertTrue(isEven(2))),
                DynamicTest.dynamicTest("2nd dynamic test", () -> assertTrue(isEven(4))),
                DynamicTest.dynamicTest("3rd dynamic test", () -> assertFalse(isEven(3)))
        );
    }

    private boolean isEven(int number) {
        return number % 2 == 0;
    }
}

Here is my configuration:

    <dependencies>
        <dependency>
            <groupId>org.junit.jupiter</groupId>
            <artifactId>junit-jupiter</artifactId>
            <scope>test</scope>
        </dependency>
        <dependency>
            <groupId>org.junit.platform</groupId>
            <artifactId>junit-platform-launcher</artifactId>
            <scope>test</scope>
        </dependency>
        ...
    </dependencies>

    <dependencyManagement>
        <dependencies>
            <dependency>
                <groupId>org.junit</groupId>
                <artifactId>junit-bom</artifactId>
                <version>5.12.2</version>
                <type>pom</type>
                <scope>import</scope>
            </dependency>
        </dependencies>
    </dependencyManagement>

    <build>
        <plugins>
            <plugin>
                <groupId>org.apache.maven.plugins</groupId>
                <artifactId>maven-surefire-plugin</artifactId>
                <version>3.5.3</version>
                <configuration>
                    <argLine>--add-exports java.base/sun.nio.ch=ALL-UNNAMED</argLine>
                    <useModulePath>false</useModulePath> <!-- mandatory for JUnit 5 -->
                    <systemProperties>
                        <property>
                            <name>junit.jupiter.displayname.generator.default</name>
                            <value>org.junit.jupiter.api.DisplayNameGenerator$Standard</value>
                        </property>
                    </systemProperties>
                </configuration>
            </plugin>
            ...
        </plugins>
    </build>

Also reported in Surefire issues.

[marcphilipp]

I left a comment on the Surefire issue. Closing since the report is generated by Surefire in this case. Please consider adopting Open Test Reporting if you'd like to have support for all JUnit features or a decent HTML report. 😉

[NicoLaval]

I tried to play with dorny/test-reporter@v2 to display results in Github.

Here was my CI file and here my surefire configuration for open test reporting.

[marcphilipp]

Looks useful! I'm not aware of anything like that for OTR, yet. If you want, could you please raise an issue and link it here?

[NicoLaval]

Hi @marcphilipp,

Where do you want me to open an issue? On the dorny/test-reporter@v2 repo?

[marcphilipp]

Yep

[NicoLaval]

Done here