Support suppressed exceptions when trimming stack trace #1451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
panchenko
force-pushed
the
trim_suppressed
branch
from
59bda29 to
0c357b9
Compare
kcooney
approved these changes
May 25, 2017
| } | ||
|
|
||
| private static boolean hasSuppressed(Throwable exception) { | ||
| if (getSuppressed != null) { |
There was a problem hiding this comment.
nit: I personally prefer existing out on error conditions early, to avoid over-intentation:
if (getSuppressed == null) {
return false;
}
try {
...
} catch (Throwable e) {
return false;
}
sebasjm
pushed a commit
to sebasjm/junit4
that referenced
this pull request
Mar 11, 2018
aristotle0x01
pushed a commit
to aristotle0x01/junit4
that referenced
this pull request
Jun 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1426