Skip to content

Commit a7202f3

Browse files
committed
Removed Comparators.reverse(); it's broken and the JDK provides a better version
1 parent ca3e040 commit a7202f3

File tree

4 files changed

+3
-11
lines changed

4 files changed

+3
-11
lines changed

src/test/java/org/junit/tests/manipulation/Comparators.java

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -16,12 +16,4 @@ private Comparators() {}
1616
public static Comparator<Description> alphanumeric() {
1717
return ALPHANUMERIC;
1818
}
19-
20-
public static Comparator<Description> reverse(final Comparator<Description> comparator) {
21-
return new Comparator<Description>() {
22-
public int compare(Description o1, Description o2) {
23-
return ALPHANUMERIC.compare(o2, o1);
24-
}
25-
};
26-
}
2719
}

src/test/java/org/junit/tests/manipulation/ReverseAlphanumericOrdering.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ public final class ReverseAlphanumericOrdering extends ComparatorBasedOrdering
99
implements Ordering.Factory {
1010

1111
public ReverseAlphanumericOrdering() {
12-
super(Comparators.reverse(Comparators.alphanumeric()));
12+
super(Comparators.alphanumeric().reversed());
1313
}
1414

1515
public Ordering create(Context context) {

src/test/java/org/junit/tests/manipulation/ReverseAlphanumericSorter.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,6 @@
99
public final class ReverseAlphanumericSorter implements Ordering.Factory {
1010

1111
public Ordering create(Ordering.Context context) {
12-
return new Sorter(Comparators.reverse(Comparators.alphanumeric()));
12+
return new Sorter(Comparators.alphanumeric().reversed());
1313
}
1414
}

src/test/java/org/junit/tests/manipulation/SortableTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ private static Comparator<Description> forward() {
2626
}
2727

2828
private static Comparator<Description> backward() {
29-
return Comparators.reverse(Comparators.alphanumeric());
29+
return Comparators.alphanumeric().reversed();
3030
}
3131

3232
public static class TestClassRunnerIsSortable {

0 commit comments

Comments
 (0)