Skip to content

Rename new @ParameterizedTest attributes to avoid confusion #4137

Closed
@marcphilipp

Description

@marcphilipp

With #3708 (PR #4045) adding argumentCountValidation to @ParameterizedTest, I feel like there is a bit lack of clarity for users about what requireArguments does compared to argumentCountValidation. Specifically, I think it's not very clear which of these applies to arguments within an argument set and which applies to argument sets, if that is even the right wording.

@marcphilipp since you worked on both PRs, what's your opinion on this?
Maybe, it'd make sense to rename requireArguments to requireArgumentSets and improve the docs? Or it's not that big of a deal. I'm not sure.

For context these are the two fields in @ParameterizedTest: https://github.com/junit-team/junit5/blob/490e663244d506223d9e7b2aa1864576e44446cd/junit-jupiter-params/src/main/java/org/junit/jupiter/params/ParameterizedTest.java#L295-L325

Originally posted by @JonasJebing in #1477

Deliverables

  • Rename one or both attributes to make their effect clearer

Metadata

Metadata

Assignees

Type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions