|
4 | 4 |
|
5 | 5 | We welcome new contributors to the project!
|
6 | 6 | If you're interested, please check for [issues labeled with `up-for-grabs`
|
7 |
| -that are not yet in progress](https://github.com/junit-team/junit5/issues?q=sort%3Aupdated-desc%20is%3Aissue%20is%3Aopen%20label%3Aup-for-grabs%20-label%3A%22status%3A%20in%20progress%22). |
| 7 | +that are not yet in progress](https://github.com/junit-team/junit-framework/issues?q=sort%3Aupdated-desc%20is%3Aissue%20is%3Aopen%20label%3Aup-for-grabs%20-label%3A%22status%3A%20in%20progress%22). |
8 | 8 | Generally, before you work on an issue, post a comment and ask whether it can be started.
|
9 | 9 | Please wait for the core team to respond and assign the issue to you before making any code
|
10 | 10 | changes.
|
@@ -36,7 +36,7 @@ Issue: #999
|
36 | 36 |
|
37 | 37 | ## Pull Requests
|
38 | 38 |
|
39 |
| -Our [Definition of Done](https://github.com/junit-team/junit5/wiki/Definition-of-Done) |
| 39 | +Our [Definition of Done](https://github.com/junit-team/junit-framework/wiki/Definition-of-Done) |
40 | 40 | (DoD) offers some guidelines on what we expect from a pull request.
|
41 | 41 | Feel free to open a pull request that does not fulfill all criteria, e.g. to discuss
|
42 | 42 | a certain change before polishing it, but please be aware that we will only merge it
|
@@ -111,7 +111,7 @@ code -- class names, method names, variable names, etc.
|
111 | 111 | - Favor literals (e.g., `{@literal @}`) over HTML entities.
|
112 | 112 | - New classes and methods should declare a `@since ...` tag.
|
113 | 113 | - Use `@since 5.10` instead of `@since 5.10.0`.
|
114 |
| -- Do not use `@author` tags. Instead, contributors are listed on the [GitHub](https://github.com/junit-team/junit5/graphs/contributors) page. |
| 114 | +- Do not use `@author` tags. Instead, contributors are listed on the [GitHub](https://github.com/junit-team/junit-framework/graphs/contributors) page. |
115 | 115 | - Do not use verbs in third-person form in the first sentence of the Javadoc for a method -- for example, use "Discover tests..." instead of "Discovers tests...".
|
116 | 116 |
|
117 | 117 | #### Examples
|
@@ -140,8 +140,8 @@ See [`ExtensionContext`](junit-jupiter-api/src/main/java/org/junit/jupiter/api/e
|
140 | 140 | ### Logging
|
141 | 141 |
|
142 | 142 | - In general, logging should be used sparingly.
|
143 |
| -- All logging must be performed via the internal `Logger` façade provided via the JUnit [LoggerFactory](https://github.com/junit-team/junit5/blob/main/junit-platform-commons/src/main/java/org/junit/platform/commons/logging/LoggerFactory.java). |
144 |
| -- Levels defined in JUnit's [Logger](https://github.com/junit-team/junit5/blob/main/junit-platform-commons/src/main/java/org/junit/platform/commons/logging/Logger.java) façade, which delegates to Java Util Logging (JUL) for the actual logging. |
| 143 | +- All logging must be performed via the internal `Logger` façade provided via the JUnit [LoggerFactory](https://github.com/junit-team/junit-framework/blob/main/junit-platform-commons/src/main/java/org/junit/platform/commons/logging/LoggerFactory.java). |
| 144 | +- Levels defined in JUnit's [Logger](https://github.com/junit-team/junit-framework/blob/main/junit-platform-commons/src/main/java/org/junit/platform/commons/logging/Logger.java) façade, which delegates to Java Util Logging (JUL) for the actual logging. |
145 | 145 | - _error_ (JUL: `SEVERE`, Log4J: `ERROR`): extra information (in addition to an Exception) about errors that will halt execution
|
146 | 146 | - _warn_ (JUL: `WARNING`, Log4J: `WARN`): potential usage or configuration errors that should not halt execution
|
147 | 147 | - _info_ (JUL: `INFO`, Log4J: `INFO`): information the users might want to know but not by default
|
|
0 commit comments