Skip to content

Commit a08987c

Browse files
marcphilippmarcphilipp
committed
Make phase for reporting discovery issues dependent on Launcher method
If the new configuration parameter is not specified, the `Launcher` will report discovery issues during the discovery phase if `Launcher#discover(LauncherDiscoveryRequest)` is called, and during the execution phase if `Launcher#execute(LauncherDiscoveryRequest, TestExecutionListener...)` is called.
1 parent aa0e34d commit a08987c

File tree

10 files changed

+111
-55
lines changed

10 files changed

+111
-55
lines changed

‎junit-platform-launcher/src/main/java/org/junit/platform/launcher/LauncherConstants.java‎

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -253,7 +253,12 @@ public class LauncherConstants {
253253
*
254254
* <p>Supported values are "discovery" or "execution".
255255
*
256-
* <p>If not specified, the default is "execution".
256+
* <p>If not specified, the {@code Launcher} will report discovery issues
257+
* during the discovery phase if
258+
* {@link Launcher#discover(LauncherDiscoveryRequest)} is called, and during
259+
* the execution phase if
260+
* {@link Launcher#execute(LauncherDiscoveryRequest, TestExecutionListener...)}
261+
* is called.
257262
*
258263
* @since 1.13
259264
* @see #CRITICAL_DISCOVERY_ISSUE_SEVERITY_PROPERTY_NAME

‎junit-platform-launcher/src/main/java/org/junit/platform/launcher/core/DefaultLauncher.java‎

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,8 @@
1212

1313
import static java.util.Collections.unmodifiableCollection;
1414
import static org.junit.platform.engine.support.store.NamespacedHierarchicalStore.CloseAction.closeAutoCloseables;
15-
import static org.junit.platform.launcher.core.EngineDiscoveryOrchestrator.Phase.DISCOVERY;
16-
import static org.junit.platform.launcher.core.EngineDiscoveryOrchestrator.Phase.EXECUTION;
15+
import static org.junit.platform.launcher.core.LauncherPhase.DISCOVERY;
16+
import static org.junit.platform.launcher.core.LauncherPhase.EXECUTION;
1717

1818
import java.util.Collection;
1919

@@ -100,8 +100,7 @@ public void execute(TestPlan testPlan, TestExecutionListener... listeners) {
100100
execute((InternalTestPlan) testPlan, listeners);
101101
}
102102

103-
private LauncherDiscoveryResult discover(LauncherDiscoveryRequest discoveryRequest,
104-
EngineDiscoveryOrchestrator.Phase phase) {
103+
private LauncherDiscoveryResult discover(LauncherDiscoveryRequest discoveryRequest, LauncherPhase phase) {
105104
return discoveryOrchestrator.discover(discoveryRequest, phase);
106105
}
107106

‎junit-platform-launcher/src/main/java/org/junit/platform/launcher/core/DiscoveryIssueNotifier.java‎

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -14,19 +14,16 @@
1414
import static java.util.Comparator.comparing;
1515
import static java.util.stream.Collectors.partitioningBy;
1616
import static org.junit.platform.commons.util.ExceptionUtils.readStackTrace;
17-
import static org.junit.platform.launcher.LauncherConstants.DISCOVERY_ISSUE_FAILURE_PHASE_PROPERTY_NAME;
1817

1918
import java.util.ArrayList;
2019
import java.util.List;
2120
import java.util.Map;
22-
import java.util.Optional;
2321
import java.util.function.Consumer;
2422
import java.util.function.Supplier;
2523

2624
import org.junit.platform.commons.logging.Logger;
2725
import org.junit.platform.commons.logging.LoggerFactory;
2826
import org.junit.platform.commons.util.Preconditions;
29-
import org.junit.platform.engine.ConfigurationParameters;
3027
import org.junit.platform.engine.DiscoveryIssue;
3128
import org.junit.platform.engine.DiscoveryIssue.Severity;
3229
import org.junit.platform.engine.TestEngine;
@@ -143,9 +140,4 @@ else if (source instanceof ClassSource) {
143140
private static void appendIdeCompatibleLink(StringBuilder message, String className, String methodName) {
144141
message.append("\n at ").append(className).append(".").append(methodName).append("(SourceFile:0)");
145142
}
146-
147-
static boolean handleDiscoveryIssuesInDiscoveryPhase(ConfigurationParameters configurationParameters) {
148-
Optional<String> phase = configurationParameters.get(DISCOVERY_ISSUE_FAILURE_PHASE_PROPERTY_NAME);
149-
return "discovery".equalsIgnoreCase(phase.orElse(null));
150-
}
151143
}

‎junit-platform-launcher/src/main/java/org/junit/platform/launcher/core/EngineDiscoveryOrchestrator.java‎

Lines changed: 30 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -13,13 +13,12 @@
1313
import static java.util.stream.Collectors.joining;
1414
import static org.apiguardian.api.API.Status.INTERNAL;
1515
import static org.junit.platform.engine.Filter.composeFilters;
16-
import static org.junit.platform.launcher.core.DiscoveryIssueNotifier.handleDiscoveryIssuesInDiscoveryPhase;
16+
import static org.junit.platform.launcher.core.LauncherPhase.getDiscoveryIssueFailurePhase;
1717

1818
import java.util.Collection;
1919
import java.util.LinkedHashMap;
2020
import java.util.LinkedList;
2121
import java.util.List;
22-
import java.util.Locale;
2322
import java.util.Map;
2423
import java.util.Optional;
2524
import java.util.function.Function;
@@ -29,6 +28,7 @@
2928
import org.junit.platform.commons.logging.Logger;
3029
import org.junit.platform.commons.logging.LoggerFactory;
3130
import org.junit.platform.commons.util.UnrecoverableExceptions;
31+
import org.junit.platform.engine.ConfigurationParameters;
3232
import org.junit.platform.engine.Filter;
3333
import org.junit.platform.engine.FilterResult;
3434
import org.junit.platform.engine.TestDescriptor;
@@ -69,15 +69,19 @@ public EngineDiscoveryOrchestrator(Iterable<TestEngine> testEngines,
6969
}
7070

7171
/**
72-
* Discovers tests for the supplied request in the supplied phase using the
73-
* configured test engines.
72+
* Discovers tests for the supplied request using the configured test
73+
* engines.
7474
*
7575
* <p>Applies {@linkplain org.junit.platform.launcher.EngineFilter engine
7676
* filters} and {@linkplain PostDiscoveryFilter post-discovery filters} and
7777
* {@linkplain TestDescriptor#prune() prunes} the resulting test tree.
7878
*/
79-
public LauncherDiscoveryResult discover(LauncherDiscoveryRequest request, Phase phase) {
80-
return discover(request, phase, UniqueId::forEngine);
79+
public LauncherDiscoveryResult discover(LauncherDiscoveryRequest request) {
80+
return discover(request, Optional.empty(), UniqueId::forEngine);
81+
}
82+
83+
LauncherDiscoveryResult discover(LauncherDiscoveryRequest request, LauncherPhase phase) {
84+
return discover(request, Optional.of(phase), UniqueId::forEngine);
8185
}
8286

8387
/**
@@ -94,12 +98,12 @@ public LauncherDiscoveryResult discover(LauncherDiscoveryRequest request, Phase
9498
* {@link EngineExecutionOrchestrator} will not emit start or emit events
9599
* for engines without tests.
96100
*/
97-
public LauncherDiscoveryResult discover(LauncherDiscoveryRequest request, Phase phase, UniqueId parentId) {
98-
LauncherDiscoveryResult result = discover(request, phase, parentId::appendEngine);
101+
public LauncherDiscoveryResult discover(LauncherDiscoveryRequest request, UniqueId parentId) {
102+
LauncherDiscoveryResult result = discover(request, Optional.empty(), parentId::appendEngine);
99103
return result.withRetainedEngines(TestDescriptor::containsTests);
100104
}
101105

102-
private LauncherDiscoveryResult discover(LauncherDiscoveryRequest request, Phase phase,
106+
private LauncherDiscoveryResult discover(LauncherDiscoveryRequest request, Optional<LauncherPhase> phase,
103107
Function<String, UniqueId> uniqueIdCreator) {
104108
DiscoveryIssueCollector issueCollector = new DiscoveryIssueCollector(request.getConfigurationParameters());
105109
LauncherDiscoveryListener listener = getLauncherDiscoveryListener(request, issueCollector);
@@ -120,13 +124,20 @@ public LauncherDiscoveryListener getDiscoveryListener() {
120124
finally {
121125
listener.launcherDiscoveryFinished(request);
122126
}
123-
if (handleDiscoveryIssuesInDiscoveryPhase(request.getConfigurationParameters())) {
124-
handleDiscoveryIssues(discoveryResult);
127+
if (shouldReportDiscoveryIssues(request, phase)) {
128+
reportDiscoveryIssues(discoveryResult);
125129
}
126130
return discoveryResult;
127131
}
128132

129-
private static void handleDiscoveryIssues(LauncherDiscoveryResult discoveryResult) {
133+
private static boolean shouldReportDiscoveryIssues(LauncherDiscoveryRequest request,
134+
Optional<LauncherPhase> phase) {
135+
ConfigurationParameters configurationParameters = request.getConfigurationParameters();
136+
return getDiscoveryIssueFailurePhase(configurationParameters).orElse(
137+
phase.orElse(null)) == LauncherPhase.DISCOVERY;
138+
}
139+
140+
private static void reportDiscoveryIssues(LauncherDiscoveryResult discoveryResult) {
130141
DiscoveryIssueException exception = null;
131142
for (TestEngine testEngine : discoveryResult.getTestEngines()) {
132143
EngineResultInfo engineResult = discoveryResult.getEngineResult(testEngine);
@@ -142,23 +153,23 @@ private static void handleDiscoveryIssues(LauncherDiscoveryResult discoveryResul
142153
}
143154
}
144155

145-
private Map<TestEngine, EngineResultInfo> discoverSafely(LauncherDiscoveryRequest request, Phase phase,
146-
DiscoveryIssueCollector issueCollector, Function<String, UniqueId> uniqueIdCreator) {
156+
private Map<TestEngine, EngineResultInfo> discoverSafely(LauncherDiscoveryRequest request,
157+
Optional<LauncherPhase> phase, DiscoveryIssueCollector issueCollector,
158+
Function<String, UniqueId> uniqueIdCreator) {
147159
Map<TestEngine, EngineResultInfo> testEngineDescriptors = new LinkedHashMap<>();
148160
EngineFilterer engineFilterer = new EngineFilterer(request.getEngineFilters());
149161

150162
for (TestEngine testEngine : this.testEngines) {
151163
boolean engineIsExcluded = engineFilterer.isExcluded(testEngine);
152164

153165
if (engineIsExcluded) {
154-
logger.debug(() -> String.format(
155-
"Test discovery for engine '%s' was skipped due to an EngineFilter in %s phase.",
156-
testEngine.getId(), phase));
166+
logger.debug(() -> String.format("Test discovery for engine '%s' was skipped due to an EngineFilter%s.",
167+
testEngine.getId(), phase.map(it -> String.format(" in %s phase", it)).orElse("")));
157168
continue;
158169
}
159170

160-
logger.debug(() -> String.format("Discovering tests during Launcher %s phase in engine '%s'.", phase,
161-
testEngine.getId()));
171+
logger.debug(() -> String.format("Discovering tests%s in engine '%s'.",
172+
phase.map(it -> String.format(" during Launcher %s phase", it)).orElse(""), testEngine.getId()));
162173

163174
EngineResultInfo engineResult = discoverEngineRoot(testEngine, request, issueCollector, uniqueIdCreator);
164175
testEngineDescriptors.put(testEngine, engineResult);
@@ -263,13 +274,4 @@ private void acceptInAllTestEngines(Map<TestEngine, EngineResultInfo> testEngine
263274
testEngineResults.values().forEach(result -> result.getRootDescriptor().accept(visitor));
264275
}
265276

266-
public enum Phase {
267-
DISCOVERY, EXECUTION;
268-
269-
@Override
270-
public String toString() {
271-
return name().toLowerCase(Locale.ENGLISH);
272-
}
273-
}
274-
275277
}

‎junit-platform-launcher/src/main/java/org/junit/platform/launcher/core/EngineExecutionOrchestrator.java‎

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
import static org.apiguardian.api.API.Status.INTERNAL;
1414
import static org.junit.platform.launcher.LauncherConstants.DRY_RUN_PROPERTY_NAME;
1515
import static org.junit.platform.launcher.LauncherConstants.STACKTRACE_PRUNING_ENABLED_PROPERTY_NAME;
16-
import static org.junit.platform.launcher.core.DiscoveryIssueNotifier.handleDiscoveryIssuesInDiscoveryPhase;
16+
import static org.junit.platform.launcher.core.LauncherPhase.getDiscoveryIssueFailurePhase;
1717
import static org.junit.platform.launcher.core.ListenerRegistry.forEngineExecutionListeners;
1818

1919
import java.util.Optional;
@@ -186,10 +186,9 @@ private static EngineExecutionListener selectExecutionListener(EngineExecutionLi
186186
private void failOrExecuteEngine(LauncherDiscoveryResult discoveryResult, EngineExecutionListener listener,
187187
TestEngine testEngine, NamespacedHierarchicalStore<Namespace> requestLevelStore) {
188188
EngineResultInfo engineDiscoveryResult = discoveryResult.getEngineResult(testEngine);
189-
DiscoveryIssueNotifier discoveryIssueNotifier = handleDiscoveryIssuesInDiscoveryPhase(
190-
discoveryResult.getConfigurationParameters()) //
191-
? DiscoveryIssueNotifier.NO_ISSUES //
192-
: engineDiscoveryResult.getDiscoveryIssueNotifier();
189+
DiscoveryIssueNotifier discoveryIssueNotifier = shouldReportDiscoveryIssues(discoveryResult) //
190+
? engineDiscoveryResult.getDiscoveryIssueNotifier() //
191+
: DiscoveryIssueNotifier.NO_ISSUES;
193192
TestDescriptor engineDescriptor = engineDiscoveryResult.getRootDescriptor();
194193
Throwable failure = engineDiscoveryResult.getCause() //
195194
.orElseGet(() -> discoveryIssueNotifier.createExceptionForCriticalIssues(testEngine));
@@ -207,6 +206,12 @@ private void failOrExecuteEngine(LauncherDiscoveryResult discoveryResult, Engine
207206
}
208207
}
209208

209+
private static boolean shouldReportDiscoveryIssues(LauncherDiscoveryResult discoveryResult) {
210+
ConfigurationParameters configurationParameters = discoveryResult.getConfigurationParameters();
211+
return getDiscoveryIssueFailurePhase(configurationParameters).orElse(
212+
LauncherPhase.EXECUTION) == LauncherPhase.EXECUTION;
213+
}
214+
210215
private ListenerRegistry<TestExecutionListener> buildListenerRegistryForExecution(
211216
TestExecutionListener... listeners) {
212217
if (listeners.length == 0) {

‎junit-platform-launcher/src/main/java/org/junit/platform/launcher/core/LauncherPhase.java‎

Lines changed: 51 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,51 @@
1+
/*
2+
* Copyright 2015-2025 the original author or authors.
3+
*
4+
* All rights reserved. This program and the accompanying materials are
5+
* made available under the terms of the Eclipse Public License v2.0 which
6+
* accompanies this distribution and is available at
7+
*
8+
* https://www.eclipse.org/legal/epl-v20.html
9+
*/
10+
11+
package org.junit.platform.launcher.core;
12+
13+
import static org.junit.platform.launcher.LauncherConstants.DISCOVERY_ISSUE_FAILURE_PHASE_PROPERTY_NAME;
14+
15+
import java.util.Locale;
16+
import java.util.Optional;
17+
18+
import org.junit.platform.commons.logging.Logger;
19+
import org.junit.platform.commons.logging.LoggerFactory;
20+
import org.junit.platform.engine.ConfigurationParameters;
21+
22+
/**
23+
* The phase the {@link org.junit.platform.launcher.Launcher} is in.
24+
*
25+
* @since 1.13
26+
*/
27+
enum LauncherPhase {
28+
29+
DISCOVERY, EXECUTION;
30+
31+
private static final Logger logger = LoggerFactory.getLogger(LauncherPhase.class);
32+
33+
static Optional<LauncherPhase> getDiscoveryIssueFailurePhase(ConfigurationParameters configurationParameters) {
34+
return configurationParameters.get(DISCOVERY_ISSUE_FAILURE_PHASE_PROPERTY_NAME, value -> {
35+
try {
36+
return LauncherPhase.valueOf(value.toUpperCase(Locale.ROOT));
37+
}
38+
catch (Exception e) {
39+
logger.warn(
40+
() -> String.format("Ignoring invalid LauncherPhase '%s' set via the '%s' configuration parameter.",
41+
value, DISCOVERY_ISSUE_FAILURE_PHASE_PROPERTY_NAME));
42+
return null;
43+
}
44+
});
45+
}
46+
47+
@Override
48+
public String toString() {
49+
return name().toLowerCase(Locale.ENGLISH);
50+
}
51+
}

‎junit-platform-suite-engine/src/main/java/org/junit/platform/suite/engine/SuiteLauncher.java‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@
2323
import org.junit.platform.engine.support.store.NamespacedHierarchicalStore;
2424
import org.junit.platform.launcher.LauncherDiscoveryRequest;
2525
import org.junit.platform.launcher.core.EngineDiscoveryOrchestrator;
26-
import org.junit.platform.launcher.core.EngineDiscoveryOrchestrator.Phase;
2726
import org.junit.platform.launcher.core.EngineExecutionOrchestrator;
2827
import org.junit.platform.launcher.core.LauncherDiscoveryResult;
2928
import org.junit.platform.launcher.core.ServiceLoaderTestEngineRegistry;
@@ -56,7 +55,7 @@ private boolean hasTestEngineOtherThanSuiteEngine(Set<TestEngine> testEngines) {
5655
}
5756

5857
LauncherDiscoveryResult discover(LauncherDiscoveryRequest discoveryRequest, UniqueId parentId) {
59-
return discoveryOrchestrator.discover(discoveryRequest, Phase.DISCOVERY, parentId);
58+
return discoveryOrchestrator.discover(discoveryRequest, parentId);
6059
}
6160

6261
TestExecutionSummary execute(LauncherDiscoveryResult discoveryResult,

‎junit-platform-testkit/src/main/java/org/junit/platform/testkit/engine/EngineTestKit.java‎

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,6 @@
1717
import static org.apiguardian.api.API.Status.MAINTAINED;
1818
import static org.apiguardian.api.API.Status.STABLE;
1919
import static org.junit.platform.engine.support.store.NamespacedHierarchicalStore.CloseAction.closeAutoCloseables;
20-
import static org.junit.platform.launcher.core.EngineDiscoveryOrchestrator.Phase.DISCOVERY;
21-
import static org.junit.platform.launcher.core.EngineDiscoveryOrchestrator.Phase.EXECUTION;
2220

2321
import java.nio.file.Path;
2422
import java.util.List;
@@ -190,7 +188,7 @@ public static EngineDiscoveryResults discover(String engineId, LauncherDiscovery
190188
public static EngineDiscoveryResults discover(TestEngine testEngine, LauncherDiscoveryRequest discoveryRequest) {
191189
Preconditions.notNull(testEngine, "TestEngine must not be null");
192190
Preconditions.notNull(discoveryRequest, "EngineDiscoveryRequest must not be null");
193-
LauncherDiscoveryResult discoveryResult = discover(testEngine, discoveryRequest, DISCOVERY);
191+
LauncherDiscoveryResult discoveryResult = discoverUsingOrchestrator(testEngine, discoveryRequest);
194192
TestDescriptor engineDescriptor = discoveryResult.getEngineTestDescriptor(testEngine);
195193
List<DiscoveryIssue> discoveryIssues = discoveryResult.getDiscoveryIssues(testEngine);
196194
return new EngineDiscoveryResults(engineDescriptor, discoveryIssues);
@@ -337,7 +335,7 @@ private static void executeDirectly(TestEngine testEngine, EngineDiscoveryReques
337335

338336
private static void executeUsingLauncherOrchestration(TestEngine testEngine,
339337
LauncherDiscoveryRequest discoveryRequest, EngineExecutionListener listener) {
340-
LauncherDiscoveryResult discoveryResult = discover(testEngine, discoveryRequest, EXECUTION);
338+
LauncherDiscoveryResult discoveryResult = discoverUsingOrchestrator(testEngine, discoveryRequest);
341339
TestDescriptor engineTestDescriptor = discoveryResult.getEngineTestDescriptor(testEngine);
342340
Preconditions.notNull(engineTestDescriptor, "TestEngine did not yield a TestDescriptor");
343341
withRequestLevelStore(store -> new EngineExecutionOrchestrator().execute(discoveryResult, listener, store));
@@ -354,10 +352,10 @@ private static NamespacedHierarchicalStore<Namespace> newStore(NamespacedHierarc
354352
return new NamespacedHierarchicalStore<>(parentStore, closeAutoCloseables());
355353
}
356354

357-
private static LauncherDiscoveryResult discover(TestEngine testEngine, LauncherDiscoveryRequest discoveryRequest,
358-
EngineDiscoveryOrchestrator.Phase phase) {
355+
private static LauncherDiscoveryResult discoverUsingOrchestrator(TestEngine testEngine,
356+
LauncherDiscoveryRequest discoveryRequest) {
359357
return new EngineDiscoveryOrchestrator(singleton(testEngine), emptySet()) //
360-
.discover(discoveryRequest, phase);
358+
.discover(discoveryRequest);
361359
}
362360

363361
@SuppressWarnings("unchecked")

‎platform-tests/src/test/java/org/junit/platform/launcher/core/DefaultLauncherTests.java‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@
2525
import static org.junit.platform.engine.discovery.DiscoverySelectors.selectUniqueId;
2626
import static org.junit.platform.fakes.FaultyTestEngines.createEngineThatCannotResolveAnything;
2727
import static org.junit.platform.fakes.FaultyTestEngines.createEngineThatFailsToResolveAnything;
28+
import static org.junit.platform.launcher.LauncherConstants.DISCOVERY_ISSUE_FAILURE_PHASE_PROPERTY_NAME;
2829
import static org.junit.platform.launcher.LauncherConstants.DRY_RUN_PROPERTY_NAME;
2930
import static org.junit.platform.launcher.core.LauncherDiscoveryRequestBuilder.DEFAULT_DISCOVERY_LISTENER_CONFIGURATION_PROPERTY_NAME;
3031
import static org.junit.platform.launcher.core.LauncherDiscoveryRequestBuilder.request;
@@ -1018,6 +1019,7 @@ private static ReportedData execute(TestEngine engine, UnaryOperator<LauncherDis
10181019

10191020
var builder = request() //
10201021
.enableImplicitConfigurationParameters(false) //
1022+
.configurationParameter(DISCOVERY_ISSUE_FAILURE_PHASE_PROPERTY_NAME, "execution") //
10211023
.configurationParameter(DEFAULT_DISCOVERY_LISTENER_CONFIGURATION_PROPERTY_NAME, "logging");
10221024
var request = configurer.apply(builder).build();
10231025
var launcher = createLauncher(engine);

‎platform-tests/src/test/java/org/junit/platform/launcher/listeners/discovery/LoggingLauncherDiscoveryListenerTests.java‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@
1515
import static org.junit.platform.engine.discovery.DiscoverySelectors.selectUniqueId;
1616
import static org.junit.platform.fakes.FaultyTestEngines.createEngineThatCannotResolveAnything;
1717
import static org.junit.platform.fakes.FaultyTestEngines.createEngineThatFailsToResolveAnything;
18+
import static org.junit.platform.launcher.LauncherConstants.DISCOVERY_ISSUE_FAILURE_PHASE_PROPERTY_NAME;
1819
import static org.junit.platform.launcher.core.LauncherDiscoveryRequestBuilder.DEFAULT_DISCOVERY_LISTENER_CONFIGURATION_PROPERTY_NAME;
1920
import static org.junit.platform.launcher.core.LauncherDiscoveryRequestBuilder.request;
2021
import static org.junit.platform.launcher.core.LauncherFactoryForTestingPurposesOnly.createLauncher;
@@ -37,6 +38,7 @@ public class LoggingLauncherDiscoveryListenerTests {
3738
void logsWarningOnUnresolvedUniqueIdSelectorWithEnginePrefix(LogRecordListener log) {
3839
var engine = createEngineThatCannotResolveAnything("some-engine");
3940
var request = request() //
41+
.configurationParameter(DISCOVERY_ISSUE_FAILURE_PHASE_PROPERTY_NAME, "execution") //
4042
.configurationParameter(DEFAULT_DISCOVERY_LISTENER_CONFIGURATION_PROPERTY_NAME, "logging") //
4143
.selectors(selectUniqueId(UniqueId.forEngine(engine.getId()))) //
4244
.enableImplicitConfigurationParameters(false) //
@@ -74,6 +76,7 @@ void logsErrorOnSelectorResolutionFailure(LogRecordListener log) {
7476
var rootCause = new RuntimeException();
7577
var engine = createEngineThatFailsToResolveAnything("some-engine", rootCause);
7678
var request = request() //
79+
.configurationParameter(DISCOVERY_ISSUE_FAILURE_PHASE_PROPERTY_NAME, "execution") //
7780
.configurationParameter(DEFAULT_DISCOVERY_LISTENER_CONFIGURATION_PROPERTY_NAME, "logging") //
7881
.selectors(selectClass(Object.class)) //
7982
.enableImplicitConfigurationParameters(false) //

0 commit comments

Comments
 (0)