Skip to content

Commit 1ae5608

Browse files
committed
Polish EqualsAndHashCodeAssertions
1 parent ff1e2ee commit 1ae5608

File tree

1 file changed

+12
-7
lines changed

1 file changed

+12
-7
lines changed

junit-jupiter-api/src/testFixtures/java/org/junit/jupiter/api/EqualsAndHashCodeAssertions.java

Lines changed: 12 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -25,22 +25,27 @@ private EqualsAndHashCodeAssertions() {
2525

2626
@SuppressWarnings("EqualsWithItself")
2727
public static <T> void assertEqualsAndHashCode(T equal1, T equal2, T different) {
28+
// Prerequisites
2829
assertThat(equal1).isNotNull();
2930
assertThat(equal2).isNotNull();
3031
assertThat(different).isNotNull();
31-
3232
assertThat(equal1).isNotSameAs(equal2);
33-
assertThat(equal1).isNotNull();
33+
34+
// Are equal
35+
assertThat(equal1).isEqualTo(equal1);
36+
assertThat(equal1).isEqualTo(equal2);
37+
assertThat(equal2).isEqualTo(equal1);
38+
39+
// Are not equal
40+
assertThat(equal1).isNotEqualTo(null);
3441
assertThat(equal1).isNotEqualTo(new Object());
3542
assertThat(equal1).isNotEqualTo(different);
3643
assertThat(different).isNotEqualTo(equal1);
3744
assertThat(different).isNotEqualTo(equal2);
38-
assertThat(equal1.hashCode()).isNotEqualTo(different.hashCode());
3945

40-
assertThat(equal1).isEqualTo(equal1);
41-
assertThat(equal1).isEqualTo(equal2);
42-
assertThat(equal2).isEqualTo(equal1);
43-
assertThat(equal1.hashCode()).isEqualTo(equal2.hashCode());
46+
// Hash codes
47+
assertThat(equal1).hasSameHashCodeAs(equal2);
48+
assertThat(equal1).doesNotHaveSameHashCodeAs(different);
4449
}
4550

4651
}

0 commit comments

Comments
 (0)