Optimize memory allocation with buffer pools and slice reuse #1944
+282
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.



Addresses potential memory issues by reducing allocations in hot paths through buffer pooling and capacity-aware buffer management.
Changes
Buffer Pool Infrastructure (
pkg/utils/buffer.go)BufferPooltype wrappingsync.Poolwith configurable sizesSmallBufferPool(1KB),MediumBufferPool(32KB),LargeBufferPool(64KB)BytesBufferPoolforbytes.Bufferreuse withGetBytesBuffer()/PutBytesBuffer()helpersFTP File Operations (
pkg/proxy/recorder.go)FTPFileInfo.WriteFromReader()instead of per-call allocationZmodem Parsing (
pkg/zmodem/zsession.go)parsedSubPacketslice capacity vias.parsedSubPacket = s.parsedSubPacket[:0]subPacketBufwhen capacity exceeds 64KB to prevent memory bloatTerminal Parser (
pkg/proxy/parsercmd.go)resetInputBuf()to reset buffers and reclaim memory when capacity exceeds thresholdExample
Benchmarks
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.