Skip to content

[Nonlinear.ReverseAD] Fix use of reinterpret instead _reinterpret_unsafe #2744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 1, 2025

Conversation

odow
Copy link
Member

@odow odow commented May 1, 2025

Introduced by #2736, specifically:

https://github.com/jump-dev/MathOptInterface.jl/pull/2736/files#diff-fd2e1ad4a6c5ea5294c6e338afffbb76c837b6c4a868d949007a0229ad846ec0R187

image

I found the test case by taking the failed Juniper run, and reducing.

@odow
Copy link
Member Author

odow commented May 1, 2025

@odow odow mentioned this pull request May 1, 2025
9 tasks
@blegat
Copy link
Member

blegat commented May 1, 2025

I copy-pasted from here but I guess it's correct because we use a chunk of on there

input_ϵ = reinterpret(T, d.input_ϵ)
output_ϵ = reinterpret(T, d.output_ϵ)
for i in 1:length(x)
input_ϵ[i] = ForwardDiff.Partials((v[i],))
end

@odow odow merged commit 103fe75 into master May 1, 2025
212 of 229 checks passed
@odow odow deleted the od/fix-reinterpret branch May 1, 2025 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants