Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Utilities] Re-enable allocation test from #2018 #2034

Merged
merged 6 commits into from
Nov 11, 2022
Merged

[Utilities] Re-enable allocation test from #2018 #2034

merged 6 commits into from
Nov 11, 2022

Conversation

odow
Copy link
Member

@odow odow commented Nov 1, 2022

Tracking to see if #2017 changed.

But I don't expect it to have. This is a regression introduced by JuliaLang/julia#45222.

Closes #2017

test/Utilities/functions.jl Outdated Show resolved Hide resolved
src/Utilities/functions.jl Outdated Show resolved Hide resolved
test/Utilities/functions.jl Outdated Show resolved Hide resolved
@odow
Copy link
Member Author

odow commented Nov 3, 2022

@blegat I've changed to use InsertionSort since QuickSort allocates on Julia 1.9. Thoughts?

@odow
Copy link
Member Author

odow commented Nov 11, 2022

Merging because insertion sort is probably a better choice here anyway. We mostly work with small arrays because most constraints are sparse and have few terms.

@odow odow merged commit 292054d into master Nov 11, 2022
@odow odow deleted the odow-patch-1 branch November 11, 2022 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Test problems on nightly
1 participant