Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VelocityJS: Missing pattern: padding #923

Open
benzmuircroft opened this issue Aug 17, 2020 · 2 comments
Open

VelocityJS: Missing pattern: padding #923

benzmuircroft opened this issue Aug 17, 2020 · 2 comments

Comments

@benzmuircroft
Copy link

benzmuircroft commented Aug 17, 2020

Your system information

Checklist

  • Is this an issue with code?: [Yes/No]
  • Is this an issue with documentation?: [Yes/No]
  • Have you reproduced this in other browsers?: [Yes/No]
  • Have you checked for updates?: [Yes/No] I found the cdn link from your git
  • Have you checked for similar open issues?: [Yes/No]
$ev[j].velocity/*animate*/({
   'height': $ev[j].attr('h')+'px',
    'opacity': 1,
    'padding': '23px 8px '+(first_ev==1000?'0.08':'0')+'px',
    'margin-bottom': '4px'
},450,function(){...
@Rycochet
Copy link
Collaborator

Not a bug - that's you using it as a shortcut, and padding needs 4 values. You're passing 3 which the browser will auto-expand to four - so when it's finding the value it'll not match the three you have supplied. The solution (for now) is to either use force-feeding and supply the from value as 3 values too, or supply 4 values so the browser handles it all.

Saying that, going to leave this open, as I feel that this is a good one to have a handler for those shortcut values, and to auto-convert 1/2/3 into 4 values so it's all transparent (same for margin, border etc) :-)

@benzmuircroft
Copy link
Author

yeah, good idea!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants