Skip to content

Remove redundant AR from example #835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 8, 2023

Conversation

timbotimbo
Copy link
Collaborator

@timbotimbo timbotimbo commented Jul 2, 2023

Description

The example project contains several AR references, even though there is no AR example included.
This causes several issues for people that might not even plan to use AR.

Redundant:

Flutter:

  • 'Enable AR' toggle in the Menu that doesn't do anything.

Unity:

  • The project includes multiple AR packages using the Unity Package Manager.
    (ARFoundation, ARKit and ARcore and XR plugin management)
    These are not used by any example code.

Issues

The flutter button is confusing as users might expect AR to work in the current example.

The Unity packages cause several issues:

Anyone smart enough to use ARFoundation, will figure out how to add these packages to their project.
Let's remove these packages from the example to reduce the amount of problems that might pop up.

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@timbotimbo timbotimbo requested a review from RoyalCoder88 July 2, 2023 14:19
Copy link

@k0uhe1D k0uhe1D left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for always maintaining it!

@k0uhe1D
Copy link

k0uhe1D commented Jul 3, 2023

Just as an FYI, it is recommended to remove the following packages by default if they are not needed. This is because there is validation for the relevant packages in the internal implementation of URP, and removing them can lead to some performance optimization.

"com.unity.modules.vr": "1.0.0",
"com.unity.modules.wind": "1.0.0",
"com.unity.modules.xr": "1.0.0"

@timbotimbo
Copy link
Collaborator Author

timbotimbo commented Jul 3, 2023

@k0uhe1D
Good to know, I'll have to check that out the next time i'm using URP.

Given that those are listed under 'Built-in' instead of 'In Project', i've left those alone for now.
Someone might run into an error and I bet most tutorials don't mention enabling a built-in package.

My main purpose here was to get rid of XR Plugin Management, as I've ran into that bug multiple times when simply upgrading to different Unity versions.

@timbotimbo timbotimbo merged commit 3dc7fdb into juicycleff:master Jul 8, 2023
@timbotimbo timbotimbo deleted the Remove_AR_packages branch July 8, 2023 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants