Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconsider bundled third-party JS #65

Open
joecorcoran opened this issue Aug 21, 2015 · 1 comment
Open

Reconsider bundled third-party JS #65

joecorcoran opened this issue Aug 21, 2015 · 1 comment
Milestone

Comments

@joecorcoran
Copy link
Collaborator

Opening this discussion.

  1. json2.js is only needed for IE < 8 according to http://caniuse.com/#feat=json – can we stop shipping this and leave it to users to work out whether they need legacy IE support? I would vote to remove it and leave a helpful note about legacy support in the documentation.
  2. This is a more complex one. The version of Underscore that Judge provides is very out of date and, in retrospect, I don't like the praxis of providing dependencies as part of this library. When Judge was first written, JS dependency management tools like Bower and npm either didn't exist, or had not been widely adopted. Nowadays it's still a pretty fragmented state of affairs, but I think users can be expected to take care of it for themselves. I think the options are:
    1. Remove Underscore from the Judge project. Expect users to install it into their applications
    2. Remove Underscore from the Judge project completely, including refactoring it out of judge.js
    3. Continue to ship Underscore with Judge, make more of an effort to keep it up to date

Thoughts?

@jamesmk
Copy link
Collaborator

jamesmk commented Aug 22, 2015

  1. 👍
  2. I'd vote for (iii). If it's a true dependency I believe it should be bundled in the gem for ease of implemenation, but I agree we should keep it up to date.

The other part of the discussion here would be what version would these changes would go into? These are potenially non-backwards compatible since we'd officially be dropping some browser support. This hints at bumping the version to v3, but that's also a big jump follow the version history of the gem.

@joecorcoran joecorcoran added this to the v3 milestone Dec 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants