Skip to content

Commit 7bace89

Browse files
addaleaxjuanarbol
authored andcommitted
src: allow unique_ptrs with custom deleter in memory tracker
PR-URL: nodejs#145 Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent d3869f1 commit 7bace89

File tree

2 files changed

+0
-15
lines changed

2 files changed

+0
-15
lines changed

src/memory_tracker-inl.h

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -109,16 +109,6 @@ void MemoryTracker::TrackField(const char* edge_name,
109109
TrackField(edge_name, value.get(), node_name);
110110
}
111111

112-
template <typename T>
113-
void MemoryTracker::TrackField(const char* edge_name,
114-
const std::shared_ptr<T>& value,
115-
const char* node_name) {
116-
if (value.get() == nullptr) {
117-
return;
118-
}
119-
TrackField(edge_name, value.get(), node_name);
120-
}
121-
122112
template <typename T, bool kIsWeak>
123113
void MemoryTracker::TrackField(const char* edge_name,
124114
const BaseObjectPtrImpl<T, kIsWeak>& value,

src/memory_tracker.h

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -140,11 +140,6 @@ class MemoryTracker {
140140
inline void TrackField(const char* edge_name,
141141
const std::unique_ptr<T, D>& value,
142142
const char* node_name = nullptr);
143-
144-
template <typename T>
145-
inline void TrackField(const char* edge_name,
146-
const std::shared_ptr<T>& value,
147-
const char* node_name = nullptr);
148143
template <typename T, bool kIsWeak>
149144
void TrackField(const char* edge_name,
150145
const BaseObjectPtrImpl<T, kIsWeak>& value,

0 commit comments

Comments
 (0)