Skip to content

Commit 9bf5b03

Browse files
committed
Merge pull request Azure#416 from yoavrubin/dev
Removing the alias option from data masking rule
2 parents a89ec8b + 301140c commit 9bf5b03

13 files changed

+1734
-2472
lines changed

src/ResourceManager/Sql/Commands.Sql.Test/ScenarioTests/DataMaskingTests.ps1

Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -245,7 +245,7 @@ function Test-DatabaseDataMaskingNumberRuleLifecycle
245245
Assert-AreEqual $rule.NumberTo 56
246246

247247

248-
Set-AzureSqlDatabaseDataMaskingRule -ResourceGroupName $params.rgname -ServerName $params.serverName -DatabaseName $params.databaseName -RuleId $ruleId -AliasName "AliasNumber" -NumberFrom 67.26 -NumberTo 78.91
248+
Set-AzureSqlDatabaseDataMaskingRule -ResourceGroupName $params.rgname -ServerName $params.serverName -DatabaseName $params.databaseName -RuleId $ruleId -TableName "TableNumber1" -ColumnName "ColumnNumber1" -NumberFrom 67.26 -NumberTo 78.91
249249
$rule = Get-AzureSqlDatabaseDataMaskingRule -ResourceGroupName $params.rgname -ServerName $params.serverName -DatabaseName $params.databaseName -RuleId $ruleId
250250

251251
# Assert
@@ -254,7 +254,8 @@ function Test-DatabaseDataMaskingNumberRuleLifecycle
254254
Assert-AreEqual $rule.DatabaseName $params.databaseName
255255
Assert-AreEqual $rule.RuleId $ruleId
256256
Assert-AreEqual $rule.MaskingFunction "Number"
257-
Assert-AreEqual $rule.AliasName "AliasNumber"
257+
Assert-AreEqual $rule.TableName "TableNumber1"
258+
Assert-AreEqual $rule.ColumnName "ColumnNumber1"
258259
Assert-AreEqual $rule.NumberFrom 67.26
259260
Assert-AreEqual $rule.NumberTo 78.91
260261

@@ -316,7 +317,7 @@ function Test-DatabaseDataMaskingTextRuleLifecycle
316317
Assert-AreEqual $rule.ReplacementString "AAA"
317318
Assert-AreEqual $rule.SuffixSize 3
318319

319-
Set-AzureSqlDatabaseDataMaskingRule -ResourceGroupName $params.rgname -ServerName $params.serverName -DatabaseName $params.databaseName -RuleId $ruleId -AliasName "AliasText" -PrefixSize 4 -ReplacementString "BBB" -SuffixSize 2
320+
Set-AzureSqlDatabaseDataMaskingRule -ResourceGroupName $params.rgname -ServerName $params.serverName -DatabaseName $params.databaseName -RuleId $ruleId -TableName "TableText1" -ColumnName "ColumnText1" -PrefixSize 4 -ReplacementString "BBB" -SuffixSize 2
320321
$rule = Get-AzureSqlDatabaseDataMaskingRule -ResourceGroupName $params.rgname -ServerName $params.serverName -DatabaseName $params.databaseName -RuleId $ruleId
321322

322323
# Assert
@@ -325,7 +326,8 @@ function Test-DatabaseDataMaskingTextRuleLifecycle
325326
Assert-AreEqual $rule.DatabaseName $params.databaseName
326327
Assert-AreEqual $rule.RuleId $ruleId
327328
Assert-AreEqual $rule.MaskingFunction "Text"
328-
Assert-AreEqual $rule.AliasName "AliasText"
329+
Assert-AreEqual $rule.TableName "TableText1"
330+
Assert-AreEqual $rule.ColumnName "ColumnText1"
329331
Assert-AreEqual $rule.PrefixSize 4
330332
Assert-AreEqual $rule.ReplacementString "BBB"
331333
Assert-AreEqual $rule.SuffixSize 2
@@ -371,16 +373,13 @@ function Test-DatabaseDataMaskingRuleCreationFailures
371373
Assert-Throws { New-AzureSqlDatabaseDataMaskingRule -ResourceGroupName $params.rgname -ServerName $params.serverName -DatabaseName $params.databaseName -MaskingFunction "Default" -TableName "T1" -ColumnName "C1"}
372374
Assert-Throws { New-AzureSqlDatabaseDataMaskingRule -ResourceGroupName $params.rgname -ServerName $params.serverName -DatabaseName $params.databaseName -RuleId $ruleId -MaskingFunction "NONEXISTING" -TableName "T1" -ColumnName "C1"}
373375
Assert-Throws { New-AzureSqlDatabaseDataMaskingRule -ResourceGroupName $params.rgname -ServerName $params.serverName -DatabaseName $params.databaseName -RuleId $ruleId -MaskingFunction "Default"}
374-
Assert-Throws { New-AzureSqlDatabaseDataMaskingRule -ResourceGroupName $params.rgname -ServerName $params.serverName -DatabaseName $params.databaseName -RuleId $ruleId -MaskingFunction "Default" -ColumnName "C1" -AliasName "A1"}
375-
Assert-Throws { New-AzureSqlDatabaseDataMaskingRule -ResourceGroupName $params.rgname -ServerName $params.serverName -DatabaseName $params.databaseName -RuleId $ruleId -MaskingFunction "Default" -TableName "T1" -AliasName "A1"}
376-
Assert-Throws { New-AzureSqlDatabaseDataMaskingRule -ResourceGroupName $params.rgname -ServerName $params.serverName -DatabaseName $params.databaseName -RuleId $ruleId -MaskingFunction "Default" -TableName "T1" -ColumnName "C1" -AliasName "A1"}
376+
Assert-Throws { New-AzureSqlDatabaseDataMaskingRule -ResourceGroupName $params.rgname -ServerName $params.serverName -DatabaseName $params.databaseName -RuleId $ruleId -MaskingFunction "Default" -ColumnName "C1"}
377+
Assert-Throws { New-AzureSqlDatabaseDataMaskingRule -ResourceGroupName $params.rgname -ServerName $params.serverName -DatabaseName $params.databaseName -RuleId $ruleId -MaskingFunction "Default" -TableName "T1"}
377378
Assert-Throws { New-AzureSqlDatabaseDataMaskingRule -ResourceGroupName $params.rgname -ServerName $params.serverName -DatabaseName $params.databaseName -RuleId $ruleId -MaskingFunction "Number" -TableName "T1" -ColumnName "C1" -NumberFrom 2 -NumberTo 1}
378379

379380
New-AzureSqlDatabaseDataMaskingRule -ResourceGroupName $params.rgname -ServerName $params.serverName -DatabaseName $params.databaseName -RuleId $ruleId -MaskingFunction "Default" -TableName "TT1" -ColumnName "CC1"
380381
Assert-Throws { New-AzureSqlDatabaseDataMaskingRule -ResourceGroupName $params.rgname -ServerName $params.serverName -DatabaseName $params.databaseName -RuleId $ruleId -MaskingFunction "Default" -TableName "TT2" -ColumnName "CC2" }
381382
Assert-Throws { New-AzureSqlDatabaseDataMaskingRule -ResourceGroupName $params.rgname -ServerName $params.serverName -DatabaseName $params.databaseName -RuleId "SHOULD-FAIL" -MaskingFunction "Default" -TableName "TT1" -ColumnName "CC1"}
382-
Set-AzureSqlDatabaseDataMaskingRule -ResourceGroupName $params.rgname -ServerName $params.serverName -DatabaseName $params.databaseName -RuleId $ruleId -MaskingFunction "Default" -AliasName "AA1"
383-
Assert-Throws { New-AzureSqlDatabaseDataMaskingRule -ResourceGroupName $params.rgname -ServerName $params.serverName -DatabaseName $params.databaseName -RuleId "SHOULD-FAIL" -MaskingFunction -AliasName "AA1"}
384383

385384
Remove-AzureSqlDatabaseDataMaskingRule -ResourceGroupName $params.rgname -ServerName $params.serverName -DatabaseName $params.databaseName -RuleId $ruleId -Force
386385
}

0 commit comments

Comments
 (0)