Skip to content

Commit b1b836f

Browse files
Copilotjtemporal
andcommitted
Revert puppeteer config changes and regenerate SVG correctly
Co-authored-by: jtemporal <6595551+jtemporal@users.noreply.github.com>
1 parent 64ae9c3 commit b1b836f

File tree

5 files changed

+37
-16
lines changed

5 files changed

+37
-16
lines changed

MERMAID_CONVERTER_README.md

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -126,8 +126,6 @@ python3 scripts/generate_images_only.py --force
126126

127127
**Debug mode:** Use `--verbose` flag for detailed output
128128

129-
**Sandboxed environments (Docker, CI/CD):** A `puppeteer-config.json` file is included to configure Chrome with `--no-sandbox` flag. Update the `executablePath` if your Chrome/Chromium is in a different location than `/usr/bin/chromium`.
130-
131129
## License
132130

133131
MIT License - Feel free to adapt for your own Jekyll sites!

assets/css/embedded-fonts.css

Lines changed: 18 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

assets/img/mermaid/033-en.svg

Lines changed: 18 additions & 0 deletions
Loading

puppeteer-config.json

Lines changed: 0 additions & 4 deletions
This file was deleted.

scripts/config_manager.py

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -40,9 +40,6 @@ def _setup_paths(self):
4040
# Theme configuration
4141
self.theme_path = self.root_dir / 'gitfichas-mermaid-theme.json'
4242

43-
# Puppeteer configuration
44-
self.puppeteer_config_path = self.root_dir / 'puppeteer-config.json'
45-
4643
def _setup_directories(self):
4744
"""Create required directories if they don't exist."""
4845
self.images_dir.mkdir(parents=True, exist_ok=True)
@@ -95,7 +92,7 @@ def cleanup_temp_files(self):
9592

9693
def get_mermaid_cli_command(self, temp_file: Path, output_path: Path) -> list:
9794
"""Get the Mermaid CLI command arguments."""
98-
cmd = [
95+
return [
9996
'npx', '@mermaid-js/mermaid-cli',
10097
'-i', str(temp_file),
10198
'-o', str(output_path),
@@ -106,12 +103,6 @@ def get_mermaid_cli_command(self, temp_file: Path, output_path: Path) -> list:
106103
'--configFile', str(self.theme_path),
107104
'--cssFile', str(self.combined_css_path)
108105
]
109-
# Add puppeteer config if the file exists
110-
# Required for sandboxed environments (e.g., Docker containers, CI/CD)
111-
# where Chrome needs --no-sandbox flag to run
112-
if self.puppeteer_config_path.exists():
113-
cmd.extend(['-p', str(self.puppeteer_config_path)])
114-
return cmd
115106

116107
def get_image_path(self, front_matter: Dict[str, Any], file_path: Path) -> Path:
117108
"""Determine the output image path based on front matter and file path."""

0 commit comments

Comments
 (0)